conflict with img_assist module [#68039]

Comment	File	Size	Author
#18	quicktags.img_assist.patch_fix.txt	777 bytes	ericG
#5	drupal.quicktags.img_assist.patch.txt	772 bytes	halkeye

Comment #1

ericG CreditAttribution: ericG commented 12 June 2006 at 22:54

Looks like this bug is causing problems with CCK also:

http://drupal.org/node/68632

Log in or register to post comments

Comment #2

Bèr Kessels CreditAttribution: Bèr Kessels commented 13 June 2006 at 00:21

Hint: CCK had to abuse a theme function. Ugly, but it works. Looks like this bug is caused by that.

Log in or register to post comments

Comment #3

Bèr Kessels CreditAttribution: Bèr Kessels commented 13 June 2006 at 00:22

That should have been:
" ... Hint: Quicktags had t".

Log in or register to post comments

Comment #4

ericG CreditAttribution: ericG commented 13 June 2006 at 13:28

Thanks for that info.
I'll dig around
function theme_quicktags_textfield
and see if I can't find a fix.

Log in or register to post comments

Comment #5

halkeye CreditAttribution: halkeye commented 22 June 2006 at 23:45

File	Size
drupal.quicktags.img_assist.patch.txt	772 bytes

Turns out that img_assist uses #suffix, and your theming function didn't use it.

Patch

16:32 < halkeye> why does fapi's form_render unset #suffix if a themeing function is used?
16:33 < Heine> because the theme probably doesn't want the prefix and suffix output
16:34 < halkeye> sounds like a good enough reason
16:34 < Heine> It would be unthemeable, so it has to be unset
16:36 < halkeye> *nods* make sense, and the theme function could theme it
16:36 < Heine> glad I make sense :)

Log in or register to post comments

Comment #6

Bèr Kessels CreditAttribution: Bèr Kessels commented 23 June 2006 at 13:46

Version:	4.7.x-1.x-dev	» master
Status:	Active	» Needs review

Looks good. And will commit if I (or someone else) has time to test it.

But about img_assist: How about implementing a Very Simple hook_quicktags() in img_assist?

More info here: http://webschuur.com/node/628

Log in or register to post comments

Comment #7

halkeye CreditAttribution: halkeye commented 23 June 2006 at 16:17

you should contact the maintainer http://drupal.org/user/6521/contact

and i'm wondering about the last 2 lines of the patch, maybe it shouldn't have the if check, and just return $prefix . $content . $suffix.

Log in or register to post comments

Comment #8

kost CreditAttribution: kost commented 9 July 2006 at 20:42

After applying this patch, all textarea nemrs turned into "Array:", instead of it's normal name.

Log in or register to post comments

Comment #9

naudefj CreditAttribution: naudefj commented 11 July 2006 at 20:47

Status:

Needs review

» Needs work

Same problem - textarea names are shown are "Array:".

Log in or register to post comments

Comment #10

halkeye CreditAttribution: halkeye commented 12 July 2006 at 04:39

you using cvs or 4.7? patch was for cvs

Log in or register to post comments

Comment #11

naudefj CreditAttribution: naudefj commented 12 July 2006 at 06:17

Status:

Needs work

» Needs review

Oops - sorry! I've applied the patch against 4.7.

Log in or register to post comments

Comment #12

ericG CreditAttribution: ericG commented 27 July 2006 at 21:36

Thanks for the patch.

When I applied it (to the CVS quicktags module) I still get the form field name replaced by Array

I think that
in your patch
$content = theme('form_element', $element, $html);
needs to be
$content = theme('form_element', $element['#title'], $html);

or at least making that change worked for me.

Log in or register to post comments

Comment #13

Bèr Kessels CreditAttribution: Bèr Kessels commented 28 July 2006 at 10:08

Status:

Needs review

» Needs work

The patch needs to fix the addressed "Array:" bugs first.

Log in or register to post comments

Comment #14

halkeye CreditAttribution: halkeye commented 28 July 2006 at 19:24

Status:

Needs work

» Needs review

Actually, I already submitted a patch for that
http://drupal.org/node/70385

Thats a different issue, this is the img_assist issue.

Log in or register to post comments

Comment #15

ericG CreditAttribution: ericG commented 30 July 2006 at 14:40

in the patch you link to I see

- return theme('form_element', $element['#title'], $html);
+ return theme('form_element', $element, $html);

If I am reading this right, you are doing the exact opposite of what I suggested above (if my assumption is correct that in a patch lines prefixed with - get removed and those prefixed with + get added).

to make your patch work, I had to
remove
return theme('form_element', $element, $html);
and replace it with
return theme('form_element', $element['#title'], $html);

otherwise you are theming an array and not the title of the form field, right?

Log in or register to post comments

Comment #16

ericG CreditAttribution: ericG commented 31 July 2006 at 15:40

Title:

conflict with img_assist module

» correction

was not thinking when I wrote the above comment.

to correct myself:

To make the patch work I had to replace

$content = theme('form_element', $element, $html);

with

$content = theme('form_element', $element['#title'], $html);

Log in or register to post comments

Comment #17

ericG CreditAttribution: ericG commented 31 July 2006 at 21:16

Title:

correction

» conflict with img_assist module

Log in or register to post comments

Comment #18

ericG CreditAttribution: ericG commented 1 August 2006 at 14:02

File	Size
quicktags.img_assist.patch_fix.txt	777 bytes

attached is halkeye's patch with my fix as described above

Log in or register to post comments

Comment #19

Bèr Kessels CreditAttribution: Bèr Kessels commented 1 August 2006 at 15:19

Status:

Needs review

» Needs work

So that means the patch needs to be updated.

Log in or register to post comments

Comment #20

Bèr Kessels CreditAttribution: Bèr Kessels commented 1 August 2006 at 18:36

Status:

Needs work

» Needs review

My change in status was meant for #16. I did not notice the updates after that. Sorry.

Can someone review the latest patch by ericG in #18 please?

Log in or register to post comments

Comment #21

advosuzi CreditAttribution: advosuzi commented 8 August 2006 at 15:40

This patch (applied manually) fixed the image assist bug for me in quicktags 4.7.

Tried to load CVS version of quicktags to test but you've got a bug on line 143:
}cvs ci

Log in or register to post comments

Comment #22

lennart CreditAttribution: lennart commented 28 August 2006 at 09:45

Works for me! Thanks.

Log in or register to post comments

Comment #23

catch

he/him

English

CreditAttribution: catch commented 14 October 2006 at 12:03

Status:

Needs review

» Reviewed & tested by the community

Just applied the patch manually to drupal 4.7.3 and october 10th version of quicktags 4.7 and it works perfectly for me. Not sure of the etiquette for changing status, but changed to ready to be committed.

Log in or register to post comments

Comment #24

Bèr Kessels CreditAttribution: Bèr Kessels commented 18 October 2006 at 17:12

Status:

Reviewed & tested by the community

» Needs work

The patch fails for HEAD. please make sure it is up to date :)

ber@penelope:~/repository/contributions/modules/quicktags$ patch -p0 < quicktags.img_assist.patch_fix.txt
patching file quicktags.module
patch unexpectedly ends in middle of line
Hunk #1 FAILED at 67.
1 out of 1 hunk FAILED -- saving rejects to file quicktags.module.rej