Fixing newlines

CommentFileSizeAuthor
#7 newline_install_inc_v4.patch3.71 KBaspilicious
#4 newline_install_inc_v3.patch3.71 KBaspilicious
#2 newline_install_inc.patch2.52 KBaspilicious
newline_install_inc.patch2.52 KBaspilicious
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

jhodgdon’s picture

jhodgdon
she/her
Primary language English
CreditAttribution: jhodgdon commented

Patch is OK. It could also fix the indenting of @return text in two places:

+ *
  * @return
  *  TRUE/FALSE whether or not the directory was successfully created.
  */
@@ -769,6 +775,7 @@
  *  The desired permissions for the file.
  * @param $message
  *  (optional) Whether to output messages. Defaults to TRUE.
+ *
  * @return
  *  TRUE/FALSE whether or not we were able to fix the file's permissions.
  */

Should be 2 spaces. But the patch is definitely OK to commit as is also.

aspilicious’s picture

aspilicious CreditAttribution: aspilicious commented
FileSize
newline_install_inc.patch2.52 KB

Final reroll?

jhodgdon’s picture

jhodgdon
she/her
Primary language English
CreditAttribution: jhodgdon commented
Status: Needs review » Needs work

Indentation still not fixed in a few places.

aspilicious’s picture

aspilicious CreditAttribution: aspilicious commented
FileSize
newline_install_inc_v3.patch3.71 KB

Uploaded wrong patch, whoops
This one will do (I hope)

aspilicious’s picture

aspilicious CreditAttribution: aspilicious commented
Status: Needs work » Needs review
jhodgdon’s picture

jhodgdon
she/her
Primary language English
CreditAttribution: jhodgdon commented
Status: Needs review » Needs work 
- *  The name of the directory to create;
+ *   The name of the directory to create;

Should end in . not ; -- other than that, the last patch looks good.

aspilicious’s picture

aspilicious CreditAttribution: aspilicious commented
Status: Needs work » Reviewed & tested by the community
FileSize
newline_install_inc_v4.patch3.71 KB

Final reroll :D

Status: Reviewed & tested by the community » Needs work

The last submitted patch, newline_install_inc_v4.patch, failed testing.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
CreditAttribution: jhodgdon commented
Status: Needs work » Reviewed & tested by the community

Patch looks good. The test failure must be an unrelated glitch -- this is a doc-only patch.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
CreditAttribution: jhodgdon commented

#7: newline_install_inc_v4.patch queued for re-testing.

Dries’s picture

Dries CreditAttribution: Dries commented

Can we combine all newline patches into one patch, please?

jhodgdon’s picture

jhodgdon
she/her
Primary language English
CreditAttribution: jhodgdon commented
Status: Reviewed & tested by the community » Postponed

postponed as per http://drupal.org/node/855410#comment-3208874 and #11 above.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
CreditAttribution: jhodgdon commented
Status: Postponed » Closed (duplicate)

Closing as duplicate:
http://drupal.org/node/855170#comment-3794950