Modified code to make it mostly work with Drupal 6 and Ubercart 2

Testing.

Initial testing looks very good! It would make more sense to me for this to be a new module or a replacement for the current one which is next to unworkable. At the moment, this looks like it might be the only truly working multicurrency solution for ubercart and it's a bit lost in this issue thread!

Testing

I'm testing the module and I've found that it doesn't work with options which change the price, the prices on the options reflect the default store currency.

First screenshot is in a converted currency, the second screenshot is in the default currency.

The currency selection dropdown should have a "store default" option to return back to store defaults. I had to add NOK manually to return to store default.

Apart from that it works pretty well.

I've installed the module and it works fine! Right up until the point when the user checks out through PayPal, I've followed the instructions in the readme.txt and the currency is transfered but not the adjusted price. So if I'm ordering a product that costs £1.50 the module converts that to $2.39, but when checking out, PayPal shows the price as $1.50.

Not sure if I've made an error during the installation...

Any suggestions?

Yes, it's works fine, thanks KingJoshi. But I have one problem with views. My site works on one currency. And admin panel is work on another, default currency. I want to create exposed filter to get product by it's cost in range. But filter is work with default currency. What should I do to make the filter works with the currency on the site (secondary currency, not defualt)?

P.S. Sorry for my bad English

Great module! Works perfect. But I have one problem. I can't find where to change default currency. After installation I delete SGD, but it still used like default on Convertion Settings page.

@KingJoshi,

Great thanks, default currency feature work properly now.

Subscribe

I am testing the 1.01 version. Seems like everything works properly except for the SGD issue.

My default currency is stuck on SGD. My store currency is set to USD. I am using the code that should have fixed the issue.

By inspecting the uc_multi_currency.module, I notice:

define('UC_MULTI_CURRENCY_DEFAULT_CURRENCY', 'SGD');

I changed this setting to USD and it is working for me now. However this solution is not idea. Somehow this setting is not being corrected later in the code.

What is the mechanism in the code that will override this default?

Yes, THAT FIXED IT.

When viewing that the Store's Default Currency it shows USD. By clicking SAVE it fixes the issue. This seems to be a bug in Ubercart - that it assumes USD and behaves as though USD is set (by showing it in the field) even though it is not set.

So this needs to be a step in your module OR we need to file an issue with Ubercart to ensure there is a standard way of making that variable available to other modules.

Thanks for the quick reply.

I am having a new challenge.

I am using uc_aac with attributes and price adjustments. My attribute prices are being displayed with the units changed (I display as CAD$ or USD$), but the price amounts next to each attribute option are not being converted. This seems similar to the challenge @pkej had.

I have calculated the final result, however, and the price total for the item is correctly calculated.

Example:

USD Currency setting (USD default):
* Item = USD$44.99
* Option = +USD$35.00
* Total when option selected = $79.99 (correct)
* Exchange Rate: CAD = 1.0269 * USD

CAD Currency setting:
* Item = CAD$46.20 (correct)
* Option = +CAD$35.00 (not converted properly; should say +CAD$35.94)
* Total when option selected = CAD$82.14 (correct: $79.99 * 1.0269)

When I disable uc_aac to remove the ajax price updating, the option displays correctly with +CAD$35.94.

Is it a defect in uc_aac or uc_multi_currency?

Sorry, I was distracted with life and didn't get enough time the past couple of weeks to test properly. I will try version 1.01 tomorrow and let you know what I find. Thanks for your hard work on this!

Hi, I haven't tested the latest version because it isn't compatible with the boost-module.

I suggest that the uc_multi_currency module should add "/NOK", "/USD" etc to the end of the page url in order to create unique pages which are boostable. A different approach would be if the dropdown instead of being something you submit, instead runs a jquery-xpath query which could search through the page for all prices and configure them accordingly. Done "right" it could probably live as a fully cacheable block as well.

Another thing that could be nice for uc_multi_currency would be to autosubmit upon change of the dropdown.

I tested this module.

This change is necessary even with uc_aac disabled. I have found a new situation that the pricing was not correct:
* no uc_aac
* attributes for a product
* have attributes show total price (instead of the differential)

In this scenario, the default currency price was displayed. When I used v1.02, the correct price was displayed.

I've discovered a new issue with anonymous users.

The currency change works perfectly when logged in.

For an anonymous user, the currency switch works sometimes
* If I am viewing the cart, and use the block to switch currency, then it changes currency.
* Same for checkout process

However it doesn't work on the following pages:
* When I am viewing a category in the catalog, showing a listing of products.
* When I am viewing a product

The manner in which it is not working is as follows:
* Start in default currency (USD in my case)
* View catalog
* Change to other currency (CDN in my case)
* Result: the ajax shopping cart changes to CDN but the block shows the selector as "USD" and the prices in the catalog show USD prices.
* Then, if I click on a product, the pricing is in CDN, the block selector is CDN, and the cart are CDN.
* From that point forward, the catalog and products are in CDN.

Also:
* Start in default currency
* View a product
* Switch to other currency
* Same result - cart is correct while selector and pricing in product are not
* Click on catalog, then pricing, selector, and cart are all correct as before

Also:
* Start in Catalog in default currency
* switch currency (problem)
* change categories in catalog (problem persists)
* change categories again (problem not evident)
* change categories back and forth - some categories have the currency switched properly and some do not, and the same ones are consistent if you switch back and forth among them.

I tested with a regular shopping cart with ajax cart disabled, and same issue.
I have Ajax attributes turned off as well.
Caching - I have block caching turned off, and site caching on normal.

There's something funny with how the page load retrieves the value from the session for anonymous users. For product or catalog pages you switch on, the currency change does not apply. When you go to other product or catalog pages, some of them have the new selection and some do not. However it remembers which are which, so it seems to cache the value on a per-page basis.

The behaviour seems dependent on which page you choose to do the switch on.

Play with it here: http://healthcarebedding.com to see for yourself.

Let me know if you would like me to do anything to help you debug the issue.

Is there anything I can do to help with the anonymous user issue?

doesn't work with the uc_coupon value.
Any advice on this.

Thx

By the way, I realized I haven't posted to this thread for some time. This module works (with manual selection) to PayPal. I just updated to the latest Ubercart, reapplied the uc_paypal module hack/patch and it still functions fine passing the correct currency to PayPal.

I will catch up on the rest of the thread now... :)

I have reworked this code to support page cache.
See the attached archive and readme file.
Tested (and prepared patches) on Drupal drupal-6.22 and ubercart-6.x-2.7.

Ubercart must be patched in order this to work, patches are supplied.
Currently there are patches for PayPal and CyberSource payment methods.
Later I may add patches for uc_gift_certificate, uc_discounts_alt modules.

If you want patches for other payment methods please ask, and it would be great if you could also test them.
And you can make modifications yourself using PayPal or Cybersource as an example.

Considering cache support, it may be brutal but it works.
When caching is enabled, this module takes drupal page workflow from Drupal after hook_boot().
The cache logic is reworked so that pages are stored in the cache table with currency added to its cid.

Please test and comment.
Thanks!

I will test out Dukem's post then I will post a feedback.

After testing Dukem's code I have concluded that:

1. Multi-currency works as expected.
2. Some of the products that was previously created before patching up the code and enabling the Ubercart multi-currency module, there's a chance that the product will be broken. The SKU and sell price cannot be modified/save and stays blank. - Can anyone confirm it this?

I cannot confirm this. But i'm using an empty devel site with 1 product.
Also this module works on a production site and there were no such problems.
Can you post Drupal and Ubercart versions you are using?

On my first test, I tested it out first on a fresh drupal site with 1 product.

Versions I used was:
Ubercart 6.x-2.9
Product Power Tools 6.x-1.12(to remove the sku and other fields)
Currency 6.x-1.3

I tried to edit the one product then after I save it, I tried to edit it again but the sku and the sell price dont save it to the database. To solve this I just have to recreate the product. I think the the Power tools conflicted with the code or something...

On my second test, I tested it out on a sandbox with more populated products.
Version I used was the same as above.

The second test worked but some of the sku of the products was removed, to solve this I just added an sku. I don't know what went wrong on my first installation.

We tried this in a production site the third time(duplicate of the 2nd site) and there were no problems and it worked!

[edit: may 22, 2012]
Sometimes there's 1 refresh delay before the currency applies right (applies from tests #1-3).
The problem is that whenever I tried to change the currency the uc_multi_currency_set_currency($currency);
won't apply after selecting it first, It will then apply after another page refresh.
[/edit: may 22, 2012]

In another hand we created a simple module that connects the Internationalization(multi language) module with the currency.
whenever the user clicks a country or language, the currency will also change.
If anyone is interested I will post the module here(not on the projects page of drupal because it's not an official version of ubercart).

Check if block cache is disabled (/admin/settings/performance), I don't remember exactly, might be an issue.

I used the hook_init() to call the uc_multi_currency_set_currency()
I traced the values and It seems that uc_multi_currency_set_currency() applies the currency but it needs additional refresh can you enlighten me with block cache?

Okay we solve the caching issue...
it seems that the user_save() was causing the problem.
here's my theory: when you use the user_save()(only if you are logged in) it saves your data to the database first. Then after another request it cache the data from the database to the global $user

After using user_save() make sure that the most changeable data is stored with the cache($global $user) only if you needed to see the changes immediately.

you can do it by overriding the global $user;

on the code
uc_multi_currency.module line 569:

568:   if ($user->uid) {
569:     user_save($user, array('uc_multi_currency_code' => $currency)); //saves it to the database but it needs to be cached immediately
++ $user->uc_multi_currency_code = $currency; // save to cache
570:  }
571:  uc_multi_currency_set_session_currency($currency);

Ok, I have been searching, and searching, and found these:

http://drupal.org/project/uc_currency_convert
http://drupal.org/project/currency_cck

I know you have been working with this long now, but are these modules, not useful?

Looks like the first one doesn't work with cache (anonymous users when cache enabled).
The second one has a bit different purpose as I understand.

I am having an issue with the currency selection block. It only shows the currency symbol, but not a currency name (CAD, USD, EUR). Has anyone else experienced this?

Seems broken on Ubercart 6.x-2.11. Anyone got updated code?

@ragnaewan

I would like try your module that connects the Internationalization, I would be glad if you post your module to this thread.

Thanks