Call to undefined function drupal_get_path()

+1 I also found my error_log full of this. All cached pages served to anonymous users.

Cheers

Currently testing on a site. The patch itself seems OK. The problem I currently have is with caching overall. It seems like modules are not 'loaded' when serving a cached page. So I have a problem in the integration I wrote for Browscap. The statistics.api works, but a sub-function (called by the callback) which resides in the module, is not available, so kicking a 'Call to undefined function browscap_get_browser()' in the error_log (I am not sure if the page was served anyway, or the error presented to the user as well).

I'll be back when I have more. Most probably nothing for you to do in code, but some development guidelines for documentation to be added to cope with caching.

Makes sense to you?

I made progress vs. my issue in #5: Browscap now OK, but my other module using statistics API, ip_geoloc, now shows the same problem).

This means I believe that the patch in #4 works fine as long as no other modules are engaged in a cached page request - for which I will follow on in #1879512: API - Dealing with statistics data collection on cached page requests that makes the exact point.

All this to say RTBC :)

Hmmm - sorry to reopen.

Now I am getting the following error:

Warning: Invalid argument supplied for foreach() in better_statistics_get_default_fields() (line 178 of /..../sites/all/modules/better_statistics/better_statistics.module).

when a page is served from cache, with modules integrated through the API.

In fact I believe the problem is in line 173-4

    module_load_install('statistics');
    $schema = module_invoke('statistics', 'schema');

module_load_install() calls module_load_include() that calls drupal_get_path(). If this last is not defined, statistics.install won't be loaded and the schema result empty - leading to the error above.

Would it make sense to include statistics.install directly instead, like (not tested yet, just thinking aloud :)) :

    include_once DRUPAL_ROOT . '/includes/install.inc';
    require_once DRUPAL_ROOT . '/modules/statistics/statistics.install';
    $schema = module_invoke('statistics', 'schema');

cheers

Yep, solution in #9 worked fine for me, so here's the patch for review

Not really my playground :)

I'll be happy to review yours...

Works fine. Thanks.