Use CRON for re-generating sitemaps [#1920010]

If some of the contents has changed (new pictures or removed pictures) it could update automatically the sitemap. Also this could be done when running CRON, which might be better choice for high traffic sites (or sites which have huge amount of contents).

Comment	File	Size	Author
#10	google_image_sitemap-1920010-4.patch	4.08 KB	tamarpe
#8	google_image_sitemap-1920010-4.patch	4.08 KB	tamarpe
#4	google_image_sitemap-1920010-3.patch	1.09 KB	tamarpe
#2	1920010-2.patch	1.06 KB	iMiksu
#1	1920010-1.patch	699 bytes	iMiksu

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

iMiksu

Finland

CreditAttribution: iMiksu commented 18 February 2013 at 09:17

Status:

Active

» Needs review

File	Size
1920010-1.patch	699 bytes

Patch provided.

Comment #2

iMiksu

Finland

CreditAttribution: iMiksu commented 20 February 2013 at 09:01

File	Size
1920010-2.patch	1.06 KB

I found out that rebuild wasn't working because it was using drupal_goto() function which can't be used on CLI environment. This causes problems when runnin cron in drush.

I've fixed it in this patch by using drupal_is_cli() function.

Comment #3

tamarpe CreditAttribution: tamarpe commented 22 February 2016 at 13:48

Issue summary:	View changes
Status:	Needs review	» Needs work

It causes infinity redirect loop when running Cron via the website and not in Drush.
When checking -drupal_is_cli(), there should be another check if the path is cron.php

Comment #4

tamarpe CreditAttribution: tamarpe commented 22 February 2016 at 14:25

Status:

Needs work

» Needs review

File	Size
google_image_sitemap-1920010-3.patch	1.09 KB

I changed the check from !drupal_is_cli(), to if ((strpos(current_path(), '/google_image_sitemap'))), so it works from the button in the module settings, and cron via drush/manually.

Comment #5

santimg CreditAttribution: santimg commented 17 May 2018 at 15:15

At first I couldn't apply the patch in #4, I could after adding an empty end of file line.

When applied, I got big load times in some pages, I solved it adding strict type comparison for the strpos() function. Like this:

if (strpos(current_path(), '/google_image_sitemap') !== FALSE) {

Also check the code standards for comments please! They are missing some dots at the end of the lines. I think everything is working correctly after applying these changes.