Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.One of my users reported the following error message after creating a new post on notifications enabled content:
Undefined property: Notifications_Node_Post_Event::$notif_error in Notifications_Event->send_list() (line 555 of /sites/all/modules/notifications/notifications.event.inc).
The class declares $notif_errors, so the problem here is simply a typo. Patch will follow.
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | notifications-notif-error-2881432.patch | 433 bytes | pbirk |
Comments
Comment #2
pbirk CreditAttribution: pbirk commentedI used "grep -Rn 'notif_error' *" to complete a simple check to make sure the notif_error variable should not be used and received the following output:
notifications.event.inc:63: public $notif_errors = 0; // Number of sending errors
notifications.event.inc:555: $this->notif_error++;
notifications.install:181: 'notif_errors' => array(
notifications.install:224: foreach (array('send_start', 'send_end', 'send_time', 'notif_count', 'notif_errors', 'notif_sent', 'notif_success', 'log') as $field) {
As we can see, notif_error is only called once and the variable was previously declared $notif_errors.
Attached a patch against 7.x-1.0-alpha2+12-dev to resolve the issue.
Comment #3
tormiLGTM.