In the interest of exporting large files with multiple sheets over iterations, it would be useful to open existing sheets rather than always creating new ones.

CommentFileSizeAuthor
#2 phpexcel-open_existing_sheets-2577959-1.patch3.22 KBnerdacus
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

nerdacus created an issue. See original summary.

nerdacus’s picture

nerdacus CreditAttribution: nerdacus at Metal Toad commented
FileSize
phpexcel-open_existing_sheets-2577959-1.patch3.22 KB

Patch.

eeg’s picture

eeg CreditAttribution: eeg commented

+1 from me for this feature. This is also useful, if you're using a template with multiple sheets. That was my reason to write a similar patch, which was opening existing sheets too, but by index not by name. I've now switched to using this patch instead. Maybe using the sheet index instead of the name could be added as an option.

  • wadmiraal committed a517cf9 on 7.x-3.x authored by nerdacus 
    Issue #2577959 by nerdacus: Open Existing Sheets During Export
wadmiraal’s picture

wadmiraal CreditAttribution: wadmiraal at educa.ch commented
Status: Active » Needs work

Thanks for the patch. It would be nice to have a unit test for this as well. Do you think you could add some? Just look at tests/phpexcel.test for some examples.

I've committed your patch anyway, though. It's on dev.