Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Module Advance Script Manager to review against security
Module Advance Script Manager to review against security
Comments
Comment #2
KapilV CreditAttribution: KapilV as a volunteer and at Innoraft for Drupal Care, Drupal Association commentedComment #3
vishal.kadamThank you for applying!
Please read Review process for security advisory coverage: What to expect for more details and Security advisory coverage application checklist to understand what reviewers look for. Tips for ensuring a smooth review gives some hints for a smoother review.
The important notes are the following.
phpcs --standard=Drupal,DrupalPractice
on the project, which alone fixes most of what reviewers would report.To the reviewers
Please read How to review security advisory coverage applications, Application workflow, What to cover in an application review, and Tools to use for reviews.
The important notes are the following.
For new reviewers, I would also suggest to first read In which way the issue queue for coverage applications is different from other project queues.
Comment #4
vishal.kadamRemember to change the status to Needs review when the project is ready for review.
Comment #5
apadernoThe last 18 commits have been authored by other people, not by the person who created this application. Before that, other 12 commits were not authored from the person who is applying.
For these applications, we need a project where, in at least the branch used for the application, most of the commits (if not all the commits) have been done from the person who applies.
The purpose of these applications is reviewing a project to understand what the person who applies understands about writing secure code that follows the Drupal coding standards and correctly uses the Drupal API, not to understand what the project maintainers as group understands about those topics.
This application can only continue with another project where most of the commits (and preferable all the commits) have been done by you.
Comment #6
apadernoI am closing this application since there have not been replies to my previous comment, where I asked for a different project to use for the application, after more than five weeks.