Module Advance Script Manager to review against security

Project link

https://www.drupal.org/project/advance_script_manager

Comments

KapilV created an issue. See original summary.

KapilV’s picture

Issue tags: +View changes
vishal.kadam’s picture

Issue summary: View changes

Thank you for applying!

Please read Review process for security advisory coverage: What to expect for more details and Security advisory coverage application checklist to understand what reviewers look for. Tips for ensuring a smooth review gives some hints for a smoother review.

The important notes are the following.

  • If you have not done it yet, you should run phpcs --standard=Drupal,DrupalPractice on the project, which alone fixes most of what reviewers would report.
  • For the time this application is open, only your commits are allowed.
  • The purpose of this application is giving you a new drupal.org role that allows you to opt projects into security advisory coverage, either projects you already created, or projects you will create. The project status won't be changed by this application and no other user will be able to opt projects into security advisory policy.
  • We only accept an application per user. If you change your mind about the project to use for this application, or it is necessary to use a different project for the application, please update the issue summary with the link to the correct project and the issue title with the project name and the branch to review.

To the reviewers

Please read How to review security advisory coverage applications, Application workflow, What to cover in an application review, and Tools to use for reviews.

The important notes are the following.

  • It is preferable to wait for a Code Review Administrator before commenting on newly created applications. Code Review Administrators will do some preliminary checks that are necessary before any change on the project files is suggested.
  • Reviewers should show the output of a CLI tool only once per application.
  • It may be best to have the applicant fix things before further review.

For new reviewers, I would also suggest to first read In which way the issue queue for coverage applications is different from other project queues.

vishal.kadam’s picture

Remember to change the status to Needs review when the project is ready for review.

apaderno’s picture

Issue summary: View changes
Status: Active » Needs work
Issue tags: -View changes

The last 18 commits have been authored by other people, not by the person who created this application. Before that, other 12 commits were not authored from the person who is applying.

For these applications, we need a project where, in at least the branch used for the application, most of the commits (if not all the commits) have been done from the person who applies.
The purpose of these applications is reviewing a project to understand what the person who applies understands about writing secure code that follows the Drupal coding standards and correctly uses the Drupal API, not to understand what the project maintainers as group understands about those topics.

This application can only continue with another project where most of the commits (and preferable all the commits) have been done by you.

apaderno’s picture

Status: Needs work » Closed (won't fix)

I am closing this application since there have not been replies to my previous comment, where I asked for a different project to use for the application, after more than five weeks.