Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Problem/Motivation
Twitter branding has changed to the new X brand. The module still has Twitter everywhere. We should change the module to use the new brand and icons.
Steps to reproduce
Create social media links to point to Twitter. The links and icons are still using the old brand.
Proposed resolution
1. Replace the Twitter name with X and I think we should include some text to people understand that the service is formerly known as Twitter.
2. Replace Twitter icons with the new X icon.
Remaining tasks
TBD.
User interface changes
TBD.
API changes
TBD.
Data model changes
TBD.
| Comment | File | Size | Author |
|---|---|---|---|
| #10 | Screenshot from 2023-11-01 16-42-53.png | 11.01 KB | carolpettirossi |
| #7 | social_media_links-change_twitter_to_x-3384469-7.patch | 1.1 KB | chishiki |
| #5 | After-3384469-3-patch.png | 208.88 KB | djsagar |
| #5 | Before-3384469-3-patch.png | 225.04 KB | djsagar |
| #3 | replace_twitter_x-3384469-3.patch | 1.02 KB | Lus |
Issue fork social_media_links-3384469
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
compare
Comments
Comment #2
judapriestFont awesome has also incorporated the X logo : https://fontawesome.com/search?q=twitter&o=r
Comment #3
Lus CreditAttribution: Lus commentedI've replaced the name of the Platform plugin to X, added a description, icon name (used to add a class that is then used by fontawesome).
I've updated the version of the external fontawesome library.
So I didn't change the class name nor the url as they are still using the twitter.com url.
Comment #4
djsagar CreditAttribution: djsagar at OpenSense Labs commentedHi all,
Patch #3 working as expected, verified changes and shared attachment for reference.
RTBC +1.
Regards!
Comment #5
djsagar CreditAttribution: djsagar at OpenSense Labs commentedComment #7
chishiki CreditAttribution: chishiki at Cellar Door commentedany objection to changing the urlPrefix to x.com?
Comment #8
fengtan#3 works fine -- thanks!
With regards to setting the
urlPrefixto https://x.com instead of https://www.twitter.com/ -- I believe this would prevent users from re-saving existing URLs (they would have to update the links from x.com to twitter.com upon saving the form), which may be annoying.Also x.com currently redirects to twitter.com so people may have a hard time generating URLs with x.com.
An alternative is to create a new, distinct social network
Xon top ofTwitterso end users would be able to choose whether they want their link to be rendered with the bird icon or with an X. The domain constraint would match the network they pick.Comment #9
perrypierre CreditAttribution: perrypierre at Ramsalt Lab commented#3 working as expected.
Comment #10
carolpettirossi CreditAttribution: carolpettirossi at ImageX commentedI applied patch #7 and it works as expected.
Comment #11
carolpettirossi CreditAttribution: carolpettirossi at ImageX commentedComment #12
tawiiams CreditAttribution: tawiiams as a volunteer commentedAny idea when this will be added to a stable release?
Comment #14
Neslee Canil Pinto