Hello.

Thank you for great work, I enjoy using twitter module for automated tweets at node creation.

Anyway I have a little problem with status field of twitter form. When I create new node, twitter status for this node has default value. I can change this value to something more appropriate for this specific node, but if I click 'Preview' button after that, my status will be replaced by default one. I find this behaviour very annoying :) This small patch will fix it.

CommentFileSizeAuthor
#12 twitter-n633450-12.patch1.7 KBDamienMcKenna
#4 twitter_633450.patch1.2 KBsteinmb
#2 twitter.module.node_preview.graker.patch741 bytesgraker
twitter.node_preview.graker.patch741 bytesgraker
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

graker’s picture

graker CreditAttribution: graker commented
Status: Active » Needs review
graker’s picture

graker CreditAttribution: graker commented
FileSize
twitter.module.node_preview.graker.patch741 bytes

Oops, sorry, I confused source and destination files. Here's correct patch file.

skizzo’s picture

skizzo CreditAttribution: skizzo commented

The patch does fix the problem on my system

steinmb’s picture

steinmb CreditAttribution: steinmb commented
Version: 6.x-2.6 » 6.x-3.x-dev
FileSize
twitter_633450.patch1.2 KB

Still an issue, though the code have moved and changed quite a lot. I have almost no knowledge of the Drupal form API, but I hacked a small patch. Not sure what is best practice to keep those form values during preview, so this might be not where to fix it :)

steinmb’s picture

steinmb CreditAttribution: steinmb commented

There is an duplicate of this issue at #524370: "Announce This Post On Twitter" check box does not respect Preview that I closed, but contain some patches and ideas on best practice.

13rac1’s picture

13rac1 CreditAttribution: 13rac1 commented
Version: 6.x-3.x-dev » 6.x-5.x-dev
Status: Needs review » Needs work

I'm not sure if this is still an issue, but the patch does not apply.

$ git apply twitter_633450.patch 
twitter_633450.patch:18: trailing whitespace.
    
error: patch failed: twitter_post/twitter_post.module:131
error: twitter_post/twitter_post.module: patch does not apply
xurizaemon’s picture

xurizaemon
he/him
Location Ōtepoti, Aotearoa 🏝
CreditAttribution: xurizaemon commented
Version: 6.x-5.x-dev » 7.x-5.x-dev
Issue summary: View changes
Status: Needs work » Patch (to be ported)

Sensible suggestion, care to re-roll for 7.x-5.x?

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna commented
Parent issue: » #2402307: Plan for Twitter v7.x-5.9 release
DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna commented
Related issues: +#2402311: Plan for Twitter v6.x-5.2 release
DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna commented
Status: Patch (to be ported) » Needs work

The code needs some cleanup per the Drupal coding standards.

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna commented
Version: 7.x-5.x-dev » 6.x-5.x-dev
Parent issue: #2402307: Plan for Twitter v7.x-5.9 release » #2402311: Plan for Twitter v6.x-5.2 release
Related issues: -#2402311: Plan for Twitter v6.x-5.2 release

This problem doesn't exist in the 7.x-5.x branch, am working on testing the 6.x-5.x branch.

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna commented
Status: Needs work » Needs review
FileSize
twitter-n633450-12.patch1.7 KB

Rerolled, updated patch for D6.

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna commented
Status: Needs review » Fixed

Committed.

  • DamienMcKenna committed 9963696 on 6.x-5.x 
    Issue #633450 by graker, steinmb, DamienMcKenna: Don't loose the Twitter...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.