#1642062-6: Add TempStore for persistent, limited-term storage of non-cache data contains the patch used to work on this.

CommentFileSizeAuthor
#21 views-1658068-21.patch18.68 KBtim.plunkett
#11 views-1658068-11.patch18.67 KBtim.plunkett
#10 views-1658068-10.patch17.45 KBtim.plunkett
#6 views-1658068-6.patch17.09 KBtim.plunkett
#4 1658068-4.patch15.35 KBdamiankloip
#2 views-1658068-2.patch5.77 KBtim.plunkett
#1 views-1658068-1.patch4.08 KBtim.plunkett
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett commented
Status: Active » Needs work
FileSize
views-1658068-1.patch4.08 KB
tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett commented
FileSize
views-1658068-2.patch5.77 KB

Here's a new patch, adjusted for the changes in #1642062-20: Add TempStore for persistent, limited-term storage of non-cache data

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett commented
Issue tags: +CTools dependency
damiankloip’s picture

damiankloip CreditAttribution: damiankloip commented
Status: Needs work » Needs review
FileSize
1658068-4.patch15.35 KB

Here is the core patch from #1642062: Add TempStore for persistent, limited-term storage of non-cache data rolled into this one.

Status: Needs review » Needs work

The last submitted patch, 1658068-4.patch, failed testing.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett commented
Status: Needs work » Needs review
FileSize
views-1658068-6.patch17.09 KB

Missing the hook_schema part.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett commented
Status: Needs review » Reviewed & tested by the community

I think this is good enough. There are some added @todo's, which is fine.

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
Status: Reviewed & tested by the community » Fixed

Committed and gave xjm the credit commit.f

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett commented
Status: Closed (fixed) » Postponed
FileSize
views-1658068-10.patch17.45 KB

Reopening for the changes in #1642062-84: Add TempStore for persistent, limited-term storage of non-cache data

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett commented
FileSize
views-1658068-11.patch18.67 KB

Here's a new patch based on the new key/value approach in #1642062-96: Add TempStore for persistent, limited-term storage of non-cache data

Lars Toomre’s picture

Lars Toomre CreditAttribution: Lars Toomre commented
Status: Postponed » Needs review

Changing status for testing...

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett commented
Assigned: Unassigned » tim.plunkett
Status: Needs review » Postponed

What? No. The core issue hasn't been committed, this will meaninglessly fail.

Lars Toomre’s picture

Lars Toomre CreditAttribution: Lars Toomre commented

Sorry about that...

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
Status: Postponed » Needs review

Let's see whether it still works.

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
Issue tags: -VDC, -CTools dependency

#11: views-1658068-11.patch queued for re-testing.

Status: Needs review » Needs work
Issue tags: +VDC, +CTools dependency

The last submitted patch, views-1658068-11.patch, failed testing.

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented

This issue is currently blocked based on #1786990: [Module]Bundle is registered too late in WebTestBase::setUp()

xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm commented 
+++ b/views_ui/views_ui.moduleundefined
@@ -335,10 +334,9 @@ function views_ui_cache_load($name) {
+  $view->locked = $views_temp_store->getOwner($view->storage->name);

Hm, I don't think this method exists. We'd want to use getMetadata()? Or what am I missing?

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett commented

It's an old patch. I'll update when I get back to my laptop

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett commented
Status: Needs work » Needs review
FileSize
views-1658068-21.patch18.68 KB

This should be okay

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett commented
Assigned: tim.plunkett » Unassigned
Status: Needs review » Fixed

http://drupalcode.org/project/views.git/commit/6276b32
Committed!

Automatically closed -- issue fixed for 2 weeks with no activity.