http://drupal.org/sandbox/sourcesoft/1073030 :

This module creates a simple datepicker and a graphical calendar block using jQuery and jQueryUI(date picker). There's a new function to add datepicker in code for developers too.

This is just another step for drupal to support non-Gregorian Calendar(Read this post by KarenS for more information , although this is just a graphical calendar using standard jQueryUI). I've tried to use all standard and best-practices.

This sandbox is actually for developers. However I'll try to add some functionality to calendar block.
There's calendar blocks like https://drupal.org/project/fullcalendar and calendar systems that support Solar and Arabic like https://drupal.org/project/calendar_systems but this module goal is all about datepicker plugin for these not Georgian systems.

Calendar which are supported so far:
- Jalali (Iranian Shamsi Calendar)
- Arabic Calendar

http://drupalcode.org/sandbox/sourcesoft/1073030.git

Thank you for your time to review this :)

CommentFileSizeAuthor
#1 ss.jpg20.15 KBsourcesoft

Comments

sourcesoft’s picture

sourcesoft commented
StatusFileSize
new ss.jpg20.15 KB

This is also and screen-shot of how this block works just fine on my testing environment.

also: there's no such module to provide a block for non-Gregorian calendars so far, and I guess a lot people are looking forward to this.

sourcesoft’s picture

sourcesoft commented
Status: Active » Closed (won't fix)

It's taking too much reviewing my sandbox, I gave up though. marked it as closed. I chose not to share this with community.

The work-flow is darn slow guys.

sourcesoft’s picture

sourcesoft commented
Component: new project application » module
Issue summary: View changes
sourcesoft’s picture

sourcesoft commented
Status: Closed (won't fix) » Needs review

I'm making this issue active again due to raise of requests and new query_ui module changes.
I'm working on drupal 7 branch too.

Just committed new changes to work with latest drupal 6 version, ready to port to drupal 7.

It will be great to have this as a module not a sandbox. Also all the libraries included in this project is CPL license.

PA robot’s picture

PA robot commented
Status: Needs review » Needs work

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpgitdrupalorgsandboxsourcesoft1073030git

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

sourcesoft’s picture

sourcesoft commented
Status: Needs work » Needs review

I made few changes based on code sniffer. Few errors left are false alarms or javascript library files minified based on CPL.

singhsantosh’s picture

singhsantosh commented
Status: Needs review » Needs work

Hi,

I am not clear on the functionality of this module. What is the purpose to show a block of calendar without any dynamic data? Can you please give me some idea what is use of the block provided by the module?

sourcesoft’s picture

sourcesoft commented

It provides a block by default settings. But it's actually useful for Solar and Arabic calendar websites who want to add datepickers to input fields.

This sandbox integrates datepicker jquery plugin edited and fixed for Jalali and Arabic calendar systems to drupal jquery_ui module and adds an API to use it(it's for drupal 6 for now).

I first wanted to force users to download libraries for themselves and don't include 3rd party javascript files in module itself. But then I had to edit .js files too, to work with drupal. I followed these rules: https://drupal.org/node/422996

So basically this sandbox is actually for developers. However I'll try to add some functionality to calendar block.
There's calendar blocks like https://drupal.org/project/fullcalendar and calendar systems that support Solar and Arabic like https://drupal.org/project/calendar_systems but this module goal is all about datepicker plugin for these not Georgian systems.

sourcesoft’s picture

sourcesoft commented
Issue summary: View changes
Status: Needs work » Needs review
sourcesoft’s picture

sourcesoft commented
Title: Graphical Calendar » [D6] Graphical Calendar
Issue summary: View changes
larsdesigns’s picture

larsdesigns commented
Status: Needs review » Needs work

MANUAL REVIEW
=============
1. The third party library calendar.js is not released under the GPL. See bullet 1. https://drupal.org/node/422996
2. The third party library jquery.ui.datepicker-cc-ar.js is not released under the GPL. See bullet 1. https://drupal.org/node/422996
3. The third party library jquery.ui.datepicker-cc-fa.js is not released under the GPL. See bullet 1. https://drupal.org/node/422996
4. The HTML on line 21 of graphical_calendar.module should be returned to the block using a theme function. https://api.drupal.org/api/drupal/developer!hooks!core.php/function/hook...
5. For line 48 graphical_calendar.module <?php function datepicker_add() is not properly named. It needs the module name as a prefix. I suggest the function name of <?php graphical_calendar_datepicker_add() . See Function and Variables section at this URL: https://drupal.org/coding-standards#naming. Further adding an underscore as a prefix () will make the function private as to avoid collision with other hooks.
6. The function graphical_calendar_call_stack() on line 58 should be replaced using an implementation of Libraries API. See section 4.2: https://drupal.org/node/1587704
7. What is the purpose of this module? Maybe the picker should be implemented to be a graphical date picker for a date field?
8. Please see the automated code review below:

AUTOMATED REVIEW
================

http://pareview.sh/pareview/httpgitdrupalorgsandboxsourcesoft1073030git

sourcesoft’s picture

sourcesoft commented

Thank you so much taking time reviewing this small sandbox.
About your concerns here's what I'm gonna do:

Issue 1. calendar.js is just an snippet small code that converts calendars to eachother. Hashemi Nezhad made this snippet and put it on his website for everyone to use. I even asked him if it's ok to make a drupal module out of this. He puts a GPL license in the zip file anyway. I even had to edit it again to work with drupal like 2 other .js files.

Issue 2 and 3. jquery.ui.datepicker-cc-ar.js is actually jquery.ui.datepicker.js which is GPL but it’s edited to work with Jalali calendar system. I had to add this file to module cause user couldn’t download it manually. See 2.1 and 2.2 in https://drupal.org/node/422996 I hope this is enough to include them. And they're both GPL same as jquery and Hashemi Nezhad edited version.

Issue 4 and 6. You’re right, I’ll change this :)

Issue 5. My goal was to add a shorter function name like dsm() in devel.module but if it’s not necessary I’ll change it.

Issue 7. See https://drupal.org/comment/8418157#comment-8418157

All the automatic review errors and warnings are downloaded .js file. It doesn't need to follow standards cause it was minified first and it's jquery.ui plugin.

userballot’s picture

userballot commented

I'm a little new to working on the review process, but it seems to me that you may be somewhat stuck with cleaning up any libraries that you have edited to work with your module. I'm pretty sure that if you do have to include something yourself you are still responsible for the code format therein, unless somehow granted by Drupal administrators.

I think this case might be particularly tough because it seems like a hack (though this is me not knowing what the exact changes to jQuery UI were), because jquery.ui.datepicker.js, jquery.ui.datepicker-fa.js, and jquery.ui.datepicker-ar.js are all existing modules that probably should have been extended to make whatever changes were necessary. Just being responsible for an extension to a JQuery UI plugin seems like it would be much more maintainable.

Anyhow I could be off base, but this might be worth looking at. I know you've been waiting for this module for quite a while.

userballot’s picture

userballot commented

I also get an error trying to git clone your repo:

$ git clone http://drupalcode.org/sandbox/sourcesoft/1073030.git
Cloning into '1073030'...
fatal: http://drupalcode.org/sandbox/sourcesoft/1073030.git/info/refs not valid: is this a git repository?

Turns out the link is outdated and the URL should be at git.drupal.org
You should probably have the explicit command needed in your project description for the review thread.

sourcesoft’s picture

sourcesoft commented

git command is:
git clone http://git.drupal.org/sandbox/sourcesoft/1073030.git

I noticed it's gonna take a long time and it's a complicated workflow to approve these .js files to be a part of this module (however these files follow d.o rules anyway). There are millions of people using these calendars, if anyone needs I guess they have to clone the sandbox.

I'm done with this issue.

Thank you for your help userballot.

PA robot’s picture

PA robot commented
Status: Needs work » Closed (won't fix)

Closing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.