Simple Node Archive

Awesome module...Good work..By the way drupal is rocking...

I just took a quick look at your project.

Licensing: no issues.
Module duplication. Isn't there an archive view shipped with the views module? I think you need to explain how this does not duplicate that. Wouldn't it be relatively simple just to modify the default archive view to display in blocks? Why do we need a module for this when it can be easily done through the user interface?

I actually did this very thing on a demo site I was working on. I've attached screenshots to show you. In archive.png you can see the block in the right sidebar. In block_view.png you can see my views settings page. Does your project produce something more than this?

Hi rock man(Ramesh babu.g)......

Have you check this module....?
This functionality will be getting by views module also......You know?
Please check the difference between the two modules.

It is clear to me now also and it is a good module.

I have done block archive using views module.It is working fine.please find it below attached image name (archivewithviews.png).
But when I am posting more contents in every month,there a problem will be occurred while displaying the archive block.It will take lot of space in my webpage at left sidebar.

But now i have found Simple Node Archive module and i have used it in my website.It is working perfectly as per my requirement.This module has one important advantage is displaying the items in archive block as collapsible manner.please find the below attached images regarding displaying the archive block using the simple node archive module.Thanks to this module developers..........

Hi,
The module is very simple and is doing very good job..I find no problem using this module as a simple block and the output in the page body, but when i try to use this block in panels then comes the problem.
In the panel content list from where we select content for the panels, i can find only the block not the page, like if i have my page divided into 6 sections and if i want the block to be displayed in the 1st section and the output in the 5th section.. then how can i specify section or region for the output..Is it possible or am i missing any option which is already there...

Hi D2ev - this is a wonderful little module; I look forward to seeing it in contrib.

I think the duplication issue has been settled successfully.

I've picked out a few items that will need to be addressed before the project application can be approved. Note that this review isn't conclusive; once you've implemented the below recommendations, further review will be required.

Please let me know when you have updated your sandbox to include the below changes!

1. Coding Standards: The first major thing I've noticed is a lack of linebreaks in your code. This makes your code very difficult to read. Please read http://drupal.org/coding-standards and it's related subpages, and bring your code up to the Drupal coding standards.
2. Code documentation: There are some functions without documentation of any sort such as simple_node_archive_resultset(). Without any function documentation, there is no easy way to know what that function does. Also, there is no inline code comments. Please improve the quality of your code documentation by reading http://drupal.org/node/1354 and following those guidelines.
3. simple_node_archive_resultset() should probably be updated to take advantage of Drupal 7's new database API. Note also that you need to pass in parameters separately:
   

   
    $query = "select nid, type, title, created from {node} where status = 1";
    if ($node_type == 'custom') {
     $custom_selection = variable_get('simple_node_archive_custom_selection', array('page'));
     foreach ($custom_selection as $key => $value) {
      if ($value != '0') {
       $condition[] = "'" . $value . "'";
      }
     }
     $query .= ' and type IN (' . implode(', ', $condition) . ')';
    }
    elseif ($node_type != 'all') {
     $query .= " and type='" . $node_type . "'"; 
    }
    $query .= ' ORDER BY created DESC';
    $results = db_query($query)->fetchAll();
   $archive = array();
   foreach ($results as $row) {
     $archive[date('Y', $row->created)][date('F', $row->created)][$row->nid] = $row->title;
   }
   
   

   should be something more like

   $query = db_select("node")
     ->fields('nid', 'type', 'title', 'created')
     ->condition('status', 1)
     ->orderBy('created', 'DESC');
     
   if ($node_type == 'custom') {
     $custom_selection = variable_get('simple_node_archive_custom_selection', array('page'));
     foreach ($custom_selection as $key => $value) {
       if ($value != '0') {
         $condition[] = $value;
       }
     }
     $query->condition('type',  $condition, 'IN');
   }
   elseif ($node_type != 'all') {
     $query->condition('type',  $node_type);
   }
   $results = $query->execute();
   
   while ($row = $results->fetchObject()) {
     $archive[date('Y', $row->created)][date('F', $row->created)][$row->nid] = $row->title;
   }
   

4. Your hook_theme() implementation is missing the four parameters that should be passed in. Also, the 'variables' array for simple_node_archive does not declare default variables for 'value', 'archive_items', 'year' or 'month'.
5. You can remove the $Id$ tags from your files; they are no longer required.
6. The 'files[]' lines in your .info file are not required; only files that contain classes need to be declared in that fashion.

As a personal 'nice to have', it would be nice if you could add a way to also generate blocks per term in a given vocabulary. As an example, we have several blogs on a client site which all use the 'blog entry' content type. Each blog is tagged with a term indicating which blog it belongs to. It would be very helpful if you could select a vocabulary as well, and have a block generated for each content type / taxonomy term combination in the selected content types and vocabulary.

I was looking for something like this to create a blogger style archive block.

I have adjusted this module to work with the jQuery Menu API to create an archive block that can be expanded without page refreshes.

I have implemented this using the attached code on my site.

The changes can be found starting at line 115 to 166 in the theme_simple_node_archive function.

It may not be up to scratch to Drupal coding standards at the moment, I didn't have time to check, but it is functional. Hope it helps.

Sorry, left an error in the code and I can't seem to remove the attachment. Here's the correct version.
See above for details.

Karin

I m trying to use your code, but when I replace the simple_node_archive.module by yours the block just disappeared. Is there something to do in addition ?

Fixed : Forgot to install the JQuery Menu API Module

Excellent module. very good work and much needed for drupal. It would be great though to be able to change the url i.e. instead of saying simple_node_archive/some-link to your custom one eg new/some-link. As at the moment it is not possible to do it through admin settings.

Shemsedin

added project reviews

Hi D2ev,

Thanks for your excellent job. Can I create separate archive blocks for different content type. Actually I have different page.tpl for all content types and each page has it separate blocks for that content type.
One more thing can I use this module in my production site?
If possible please attach latest module here, I am not able to get code from git.

Thanks in advance.

Download the latest snapshot here: http://drupalcode.org/sandbox/asiq.khan/1213302.git

Thanks patrickd,

Have you any idea about my first 2 requirement ?

Hi D2ev,

Check out the documentation here for the master branch - you need to clean it out and put a README.txt in there:)
http://drupal.org/node/1127732

You also have some errors in ventral:
http://ventral.org/pareview/httpgitdrupalorgsandboxasiqkhan1213302git

Try to wrap your lines at 80 chars - http://drupalcode.org/sandbox/asiq.khan/1213302.git/blob/refs/heads/6.x-...

According to http://drupal.org/coding-standards#indenting - be sure to use an indent of 2 spaces when you nest. There's a lot of indent errors in the 6.x branch

6.x-1.0 and 7.x-1.0 are not the proper way to name branches. 1.0 and such are release tags. Your branches should be named 7.x-1.x and 6.x-1.x (actually ventral isn't picking them up because of this). Check out this for more info: http://drupal.org/node/1015226.

http://drupalcode.org/sandbox/asiq.khan/1213302.git/blob/refs/heads/6.x-... I would recommend an empty() check instead of $value != '0'; It'll catch more stuff and be more reliable. - http://php.net/manual/en/function.empty.php

Hi D2ev,

Can I create multiple archive blocks using your module ?

@D2ev: I am looking for D6 branch. Are you working on creating multiple blocks for D6 branch?

Hi D2ev,

I couldn't find any way to create multiple blocks. I checked my view list but there is no default view created for simple node archive. Please let me know if I am missing something, I have checked out latest code from #17.

* There is a view named "simple_node_archive " in views list. but Still I cant figure out how to create a new Simple Archive block for new content type.

Thanks for update D2ev,

latest code is working perfect. But my requirement is not to use texonomy. I need 2 separate blocks for blog content type and story content type. I am using a temporary method to achieve this functionality using your module. What I have done is :

1: Created another module file inside your module folder named story_archive.module.
2: Used only 2 functions inside it story_archive_block() and theme_story_archive().
3: Hard coded blog type instead of variable_get('simple_node_archive_node_type', array('page'));
4: For story content type I am using your default block from simple_node_archive.module

Now I have 2 separate blocks. It is not a best approach but I have no alternative solution for time being.

Thanks.

Hi D2ev,

Sorry for delay. pfa screen shot.

Thank you D2ev.

Now I can see 2 archive blocks in block listing. I could not find the way you mentioned here.
I would like to suggest one more thing if possible, You should create blocks using views like you are creating archives page (simple_node_archive) views. It would be best if we can create these blocks from views directly, because we can add more filters to archive blocks then.
I had to create 2 more separate blocks for blog content type (I added a cck field Featured blog). One block for featured blog and other one for simple blog.
Anyway it is an awesome module and you have resolved a very obvious requirement in Drupal archive blocks.Also I am using http://drupal.org/comment/reply/1222472/5875888#comment-5338112 to add jquery styles to listing, You can add this in this module also.

Thanks very much.

Hi

Review of the 7.x-1.x branch:

• Drupal Code Sniffer has found some issues with your code (please check the Drupal coding standards). See attachment.

This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. Get a review bonus and we will come back to your application sooner.

FILE: ...al-7-pareview/sites/all/modules/pareview_temp/test_candidate/sna.module
--------------------------------------------------------------------------------
FOUND 6 ERROR(S) AND 5 WARNING(S) AFFECTING 11 LINE(S)
--------------------------------------------------------------------------------
  92 | ERROR   | Whitespace found at end of line
 119 | ERROR   | If the line declaring an array spans longer than 80
     |         | characters, each element should be broken into its own line
 122 | ERROR   | If the line declaring an array spans longer than 80
     |         | characters, each element should be broken into its own line
 137 | WARNING | Line exceeds 80 characters; contains 90 characters
 195 | ERROR   | Inline comments must end in full-stops, exclamation marks, or
     |         | question marks
 268 | ERROR   | Whitespace found at end of line
 269 | WARNING | Line exceeds 80 characters; contains 81 characters
 347 | WARNING | Line exceeds 80 characters; contains 81 characters
 351 | ERROR   | Whitespace found at end of line
 357 | WARNING | Line exceeds 80 characters; contains 88 characters
 365 | WARNING | Line exceeds 80 characters; contains 84 characters
--------------------------------------------------------------------------------


FILE: ...view/sites/all/modules/pareview_temp/test_candidate/views/sna.views.inc
--------------------------------------------------------------------------------
FOUND 0 ERROR(S) AND 1 WARNING(S) AFFECTING 1 LINE(S)
--------------------------------------------------------------------------------
 25 | WARNING | Line exceeds 80 characters; contains 94 characters
--------------------------------------------------------------------------------


FILE: ...es/all/modules/pareview_temp/test_candidate/views/sna.views_default.inc
--------------------------------------------------------------------------------
FOUND 1 ERROR(S) AFFECTING 1 LINE(S)
--------------------------------------------------------------------------------
 11 | ERROR | Calling class constructors must always include parentheses
--------------------------------------------------------------------------------

Source: http://ventral.org/pareview - PAReview.sh online service

Please don't switch to needs work if there are only minor coding style issues

Something from the automated review:
Review of the 7.x-1.x branch:

• Drupal Code Sniffer has found some issues with your code (please check the Drupal coding standards). See attachment.

This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. Get a review bonus and we will come back to your application sooner.

FILE: ...al-7-pareview/sites/all/modules/pareview_temp/test_candidate/README.txt
--------------------------------------------------------------------------------
FOUND 0 ERROR(S) AND 6 WARNING(S) AFFECTING 6 LINE(S)
--------------------------------------------------------------------------------
 12 | WARNING | Line exceeds 80 characters; contains 89 characters
 22 | WARNING | Line exceeds 80 characters; contains 430 characters
 24 | WARNING | Line exceeds 80 characters; contains 143 characters
 26 | WARNING | Line exceeds 80 characters; contains 83 characters
 28 | WARNING | Line exceeds 80 characters; contains 93 characters
 30 | WARNING | Line exceeds 80 characters; contains 82 characters
--------------------------------------------------------------------------------

Source: http://ventral.org/pareview - PAReview.sh online service

Manual Review:
I recommend reading a bit from the Documentation Guidelines. To resolve these minor code style issues. Also I find it helpfull to run ventral.org's automated code review script PAReview.

Also I noticed your short-name doesn't match the module machine name. It should either be sna or simple_node_archive.

I am getting this error:

Notice: Undefined variable: use_jquerymenu in sna_admin_settings() (line 79 of /Applications/MAMP/htdocs/repos/drupal.org/sandboxed/sites/all/modules/repos/simple_node_archive/sna.admin.inc).

After looking at the code, I noticed that $use_jquerymenu is only being set inside a conditional. I would recommend setting $use_jquerymenu before the conditional so that there is no way that it can pass by unset.

I could not get the module to run without errors; setting back as Needs Work.

Sorry for the delay. Make sure to review more project application and get a new review bonus to get this finished faster (and add the "PAReview: review bonus" tag if you have done so).

Review of the 7.x-1.x branch:

• Drupal Code Sniffer has found some issues with your code (please check the Drupal coding standards). See attachment.

This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. Get a review bonus and we will come back to your application sooner.

manual review:

1. "$options['all'] = 'All type';": all user facing text must run through t() for translation. Also elsewhere, please check all your strings.
2. 6.x-1.x branch: sna_admin_settings(): "'#options' => $options,": this is vulnerable to XSS exploits as #options is not sanitized automatically on checkboxes by the D6 form API. See http://drupal.org/node/28984
3. sna_admin_settings(): this will not work for large vocabularies with many terms. The select list will not be usable anymore. You should probably use an autocomplete for taxonomy terms.
4. _sna_resultset(): if you are querying the node table you need to respect the node access grants, see http://api.drupal.org/api/drupal/modules!node!node.module/group/node_acc... . Also elsewhere.
5. _sna_resultset(): query method calls should be all lower case.
6. _sna_archivehtml(): use theme('item_list', ...) to generate HTML list markup.
7. _sna_nodeterms(): use the fetchAllKeyed() method and you don't need the extra foreach loop.

How can I get the latest update of the project files (D7)? I really need this one. Thanks in advance,

@masudez77

You need to goto the version controle tab of the modules project page http://drupal.org/project/1553702/git-instructions and download via git.

Also, this is the project application issue que. Questions such as this should be left to the project's own issue que. Asking a question such as this here can possibly make the project reviewers think that there is activity happening in this issue and as such they could take longer in getting back to reviewing this project.

We have found some bugs in the Drupal 6 version

1. sna.module - Line 224 - table names must be written in {NAME} format. This allows drupal to add the prefix to the table name in the database. Without the {} this module will not work on sites with table name prefix.
2. sna.module - Line 13 - it is recommended to insert description text into t() function to make it translatable. The other output texts seem to be written correctly using t() function.

It worked in my site perfectly. But when I enabled language (i18n and related modules), the block shows nothing. Can you fix this?

@masudfz77,

This is the issue queue for Project Applications. Please leave feature requests in the Project's own Issue Queue. Any feature requests left here are likely to get lost in the mix.

Also, by posting non-reviews here you reset the "Last Updated" date and make it seem like the project is already getting reviewed. Reviewers might pass over a project that looks like it was recently reviewed.

Please add all your reviews to the issue summary. Please don't remove the security tag, we keep that for statistical purposes and to show examples of security problems.

You still have a master branch in git. You should delete this.

The 6.x version has a lot of style issues: http://ventral.org/pareview/httpgitdrupalorgsandboxasiqkhan1553702git-6x-1x

The 7.x has a few minor style issues: http://ventral.org/pareview/httpgitdrupalorgsandboxasiqkhan1553702git-7x-1x

In the 7.x version,

-- You should really define your own admin permission so users can have more fine grained control over who does what.
-- You are pulling in year/month via arg() in sna_block_view(), but I don't see any error checking on these values.
-- In _sna_archivehtml(), you are relying on arg(). Investigate menu_get_object() instead.
-- Stylistically, in _sna_nodeterms(), I think the more common convention is to reserve ALLCAPS for SQL reserved keywords.
-- It isn't totally clear after you enable the module that the block is "SNA" and nor "Simple Node Archive"
-- You need to display a better message if Jquerymenu isn't installed/enabled.

In the 6.x version

-- Mostly the same applies, as the code looks nearly identical.

Removing review bonus tag, you have not done any manual review, you just posted the output of an automated review tool. Make sure to read through the source code of the other projects.

There is still a master branch, make sure to set the correct default branch: http://drupal.org/node/1659588 . Then remove the master branch, see also step 6 and 7 in http://drupal.org/node/1127732

Although the code uses quite some hard-coded arg() ugliness I think this is RTBC. Removing review bonus tag, you can add it again if you have done another 3 reviews of other projects.

no objections for more than a week, so ...

Thanks for your contribution, D2ev!

I updated your account to let you promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and get involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.