This is a simple module that allows you to integrate the Linkit module with the Markdown Editor for BUEditor module.

The project sandbox is available here: https://drupal.org/sandbox/baglerit/2184809

Coding Standards

I reviewed the module with Coder. The only issue I'm still getting is a false positive about there not being a @file comment block at the top of the javascript file.
The module doesn't raise any issues with pareview.sh

Reviews of other projects

Comments

dave bagler’s picture

Issue summary: View changes
dave bagler’s picture

Issue summary: View changes
dave bagler’s picture

Issue summary: View changes
dave bagler’s picture

Issue summary: View changes
dave bagler’s picture

Issue tags: +PAreview: review bonus
dave bagler’s picture

Priority: Normal » Major
klausi’s picture

Assigned: Unassigned » patrickd
Priority: Major » Normal
Status: Needs review » Reviewed & tested by the community
Issue tags: -PAreview: review bonus +PAreview: single application approval

Code looks good to me, although there is not much to review. Removing review bonus tag, you can add it again if you have done another 3 reviews of other projects.

Assigning to patrickd as he might have time to take a final look at this.

This project is too short to approve you as git vetted user. We are currently discussing how much code we need, but everything with less than 120 lines of code or less than 5 functions cannot be seriously reviewed. However, we can promote this single project manually to a full project for you.

dave bagler’s picture

Well that's really discouraging.

patrickd’s picture

Status: Reviewed & tested by the community » Fixed

There's indeed not much too see, but what I see is good!

I have promoted your project shortnamed with "linkit_markdown":

The project Linkit Markdown has been promoted to a full project.

New URL

Now that this experimental project has been promoted, you'll need to update the URL of your remote repository or reclone it.

Don't forget to substitute your project's new short name in the brackets below (and remove the brackets!)

git remote set-url origin BaglerIT@git.drupal.org:project/linkit_markdown.git

Here are some recommended readings to help with excellent maintainership:

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and stay involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.