[D7] Zip Archive

welcome

Link to sandbox page missing: http://drupal.org/sandbox/dimitrov.adrian/1402372

Please tell the people about functionality, installation, requirements and configuration on your project page and a readme file.
Also be a little more informative on your commit messages and tell us what exactly you have done. Also see conventions for git commit messages: http://drupal.org/node/52287

Tell us what your doing and what you think of in-line! In general you should give us more information on non-API typical stuff like your zip_archive class. Also some inline comments in your zip_archive_configuration_form() wouldn't hurt.

module_load_include('inc', 'zip_archive', 'zip_archive.class');
As you already added this class to files[] in your info, you probably don't need to do this here as it should be automatically lazy-loaded.

It appears you are working in the "master" branch in git. You should really be working in a version specific branch. The most direct documentation on this is Moving from a master branch to a version branch. For additional resources please see the documentation about release naming conventions and creating a branch in git.
You also should not yet create a tag until you finally create a release.
Review of the master branch:

• README.txt is missing, see the guidelines for in-project documentation.
• zip_archive.admin.inc in zip_archive.info: It's only necessary to declare files[] if they declare a class or interface.
• zip_archive.module in zip_archive.info: It's only necessary to declare files[] if they declare a class or interface.
• Drupal Code Sniffer has found some code style issues (please check the Drupal coding standards). See http://ventral.org/pareview/httpgitdrupalorgsandboxdimitrovadrian1402372git.

This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. Go and review some other project applications, so we can get back to yours sooner.

MANUAL REVIEW
--------------
1. On the configuration page, I filled out the form, click saved. It said it saved the values, but the fields were empty? But when I filled out the form a second time, the options were saved.

2. Once the options were saved in the config form, it did work on my local server. Seems very useful.

3. It would make things more clear if you defined what kind of path you are looking for for the first field on the config page. Is it an absolute path, relative path or drupal path?

4. It also would be great if the config page verified that it has access to the entered path. If not, it should display an error.

5. I noticed the module is put into a "PROPEOPLE" package. It is my understanding that this module should be put under the "OTHER" package. Contributed modules should generally be put into an existing package, unless it creates 3 or more other modules that it depends on (or something like that).

AUTO REVIEW
------------

The only error that I saw that should be fixed is this: Line 249 of zip_archive.class.inc ..... use double quotes to avoid having to backslash single quotes.

fix

Closing due to lack of activity. Feel free to reopen if you are still working on this application.

Multiple Applications

It appears that there have been multiple project applications opened under your username:

Project 1: http://drupal.org/node/1587176
Project 2: http://drupal.org/node/1772350
Project 3: http://drupal.org/node/1453964
Project 4: http://drupal.org/node/1406352
Project 5: http://drupal.org/node/1438600
Project 6: http://drupal.org/node/1929114

As successful completion of the project application process results in the applicant being granted the 'Create Full Projects' permission, there is no need to take multiple applications through the process. Once the first application has been successfully approved, then the applicant can promote other projects without review. Because of this, posting multiple applications is not necessary, and results in additional workload for reviewers ... which in turn results in longer wait times for everyone in the queue. With this in mind, your secondary applications have been marked as 'closed(duplicate)', with only one application left open (chosen at random).

If you prefer that we proceed through this review process with a different application than the one which was left open, then feel free to close the 'open' application as a duplicate, and re-open one of the project applications which had been closed.