Watchdog Console.Log

Welcome,

please get a review bonus first. Then try to fix issues raised by automated review tools: http://ventral.org/pareview/httpgitdrupalorgsandboxdimitrovadrian1772308git

I'm no way Drupal expert but here are some things I'd like to highlight:

1. I could not figure out how to use this module (and what is watchdog) reading just the docs. But I understand now that whenever calling watchdog() function within any part of the code it will be echoed to browser console. Maybe link to watchdog docs would help: http://api.drupal.org/api/drupal/includes%21bootstrap.inc/function/watch... ?
2. I tested outputting PHP variables to console. There's a patch attached. So what this does is output php array as json object that you can expand/contract right in the console. There's a devel module for that though and dpm() works great.
3. Shouldn’t 4. Typo in "Select wich message elements be part of message". Wich should be which. I would also do something about the repeating word 'message' and write "Select which variables are part of the message." or something like that. I don't like repeating :)
5. What does "PDB PR Sites, asset content types to tabs mapping setup." mean in watchdog_console_log.admin.inc comment?
6. I would rewrite "If you want to remove some filter, just black it’s field" to "If you want to remove a filter, empty it's field and press 'Save configuration'."
7. Shouldn't "Add source" button be named "Add filter"?
8. I understand if there are no filters set, nothing is echoed. Is this a feature? This should be mentioned in the description of the field. Doesn't make sense at first glance though.
9. Haven't seen contacts and company in README.txt Is this allowed?

My comment was cut in half (my bad):

3. Shouldn’t script.. be in template?
4. Typo in "Select wich message elements be part of message". Wich should be which. I would also do something about the repeating word 'message' and write "Select which variables are part of the message." or something like that. I don't like repeating :)
5. What does "PDB PR Sites, asset content types to tabs mapping setup." mean in watchdog_console_log.admin.inc comment?
6. I would rewrite "If you want to remove some filter, just black it’s field" to "If you want to remove a filter, empty it's field and press 'Save configuration'."
7. Shouldn't "Add source" button be named "Add filter"?
8. I understand if there are no filters set, nothing is echoed. Is this a feature? This should be mentioned in the description of the field. Doesn't make sense at first glance though.
9. Haven't seen contacts and company in README.txt Is this allowed?

Your're welcome! Good luck with getting full project access!

If you'd like to help, review my project at http://drupal.org/sandbox/hkirsman/1763900 . Just optional though ;)

1. Why do I need to add a filter in order to output a message? If I have no filters then I would expect it to output all watchdog messages.

2. If each filter field accepts a comma-separated list of types then why do we need to have the 'Add Filter' functionality? Seems redundant.

3. At the very least you should include a form validation function that checks if the entered filter type is legitimate. Right now you can put anything into the filter fields and it saves without throwing any errors. It would be really nice if you could include the types as checkboxes.

4. Tested with filter type = 'features'. I went to a feature I have installed and did a revert components. No additional watchdog message showed, but it was logged in 'Recent log messages'.

5. Tested with filter type = 'page not found'. I went to a phoney page and no additional message was displayed, but still logged in watchdog.

6. Tested with filter type = 'php'. Generated a php error which got logged in watchdog but no message was displayed.

7. How is your module different from the 'Logging and errors' feature that the devel module provides?

8. Also, the README.txt is a bit sparse. Should include where the admin config settings are located, and maybe a few examples on filter usage (e.g. a filter with a wildcard and one without, and usefulness of each)

I think there's a need for this, but only in very specific cases. I've run into the annoying situation where I'm getting no errors, and I'm getting nowhere with a solution, and I've forgotten to check watchdog, and the message is sitting in there with all sorts of good info. This would be really handy then. At the moment, I can't remember what 'type' those messages are, but I'll post back if I remember.

Closing due to lack of activity. Feel free to reopen if you are still working on this application.

Multiple Applications

It appears that there have been multiple project applications opened under your username:

Project 1: http://drupal.org/node/1587176
Project 2: http://drupal.org/node/1772350
Project 3: http://drupal.org/node/1453964
Project 4: http://drupal.org/node/1406352
Project 5: http://drupal.org/node/1438600
Project 6: http://drupal.org/node/1929114

As successful completion of the project application process results in the applicant being granted the 'Create Full Projects' permission, there is no need to take multiple applications through the process. Once the first application has been successfully approved, then the applicant can promote other projects without review. Because of this, posting multiple applications is not necessary, and results in additional workload for reviewers ... which in turn results in longer wait times for everyone in the queue. With this in mind, your secondary applications have been marked as 'closed(duplicate)', with only one application left open (chosen at random).

If you prefer that we proceed through this review process with a different application than the one which was left open, then feel free to close the 'open' application as a duplicate, and re-open one of the project applications which had been closed.