GMap Image Field

Multiple Applications

It appears that there have been multiple project applications opened under your username:

Project 1: http://drupal.org/node/1587176
Project 2: http://drupal.org/node/1772350
Project 3: http://drupal.org/node/1453964
Project 4: http://drupal.org/node/1406352
Project 5: http://drupal.org/node/1438600
Project 6: http://drupal.org/node/1929114

As successful completion of the project application process results in the applicant being granted the 'Create Full Projects' permission, there is no need to take multiple applications through the process. Once the first application has been successfully approved, then the applicant can promote other projects without review. Because of this, posting multiple applications is not necessary, and results in additional workload for reviewers ... which in turn results in longer wait times for everyone in the queue. With this in mind, your secondary applications have been marked as 'closed(duplicate)', with only one application left open (chosen at random).

If you prefer that we proceed through this review process with a different application than the one which was left open, then feel free to close the 'open' application as a duplicate, and re-open one of the project applications which had been closed.

There is still a master branch, make sure to set the correct default branch: http://drupal.org/node/1659588 . Then remove the master branch, see also step 6 and 7 in http://drupal.org/node/1127732

Manual Review

1) It should eliminate persistent variables on hook_uninstall
2) Maybe it's a good idea to add a hook_requirements and hook_enabled for ImageMagick.

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Possibly update your README.txt, specifically the installation process and introduction, they're both slightly lacking as far as content goes. Otherwise the module is pretty much exactly what you make it out to be.

adding manual reviews

Review of the 7.x-1.x branch:

• Coder Sniffer has found some issues with your code (please check the Drupal coding standards).
  

  
  FILE: /home/klausi/pareview_temp/gmap_image_field.admin.inc
  --------------------------------------------------------------------------------
  FOUND 0 ERROR(S) AND 1 WARNING(S) AFFECTING 1 LINE(S)
  --------------------------------------------------------------------------------
   27 | WARNING | Only string literals should be passed to t() where possible
  --------------------------------------------------------------------------------
  
  Time: 2 seconds, Memory: 32.25Mb
  

This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. You have to get a review bonus to get a review from me.

manual review:

1. gmap_image_field_settings_form(): why do call filter_xss() on the $message, no user provided input is involved. Please read http://drupal.org/node/28984 again. Looks like you change your code due to a false positive in coder review.
2. "escapeshellcmd('-version')": you don't need to escape this literal string?
3. gmap_image_field_field_attach_prepare_translation_alter(): doc block hook name is wrong?
4. gmap_image_field_field_attach_prepare_translation_alter(): wrong variable name, do not use $node here, use $entity.
5. gmap_image_field.inc: @file doc block is wrong, what is this plugin about?
6. README.txt: usage instructions are missing. How do I setup pins, what is the page manager (?) plugin for etc.

But otherwise looks RTBC to me. Removing review bonus tag, you can add it again if you have done another 3 reviews of other projects.

Assigning to cubeinspire as he might have time to take a final look at this.

Update introduction.

no objections for more than a week, so ...

Thanks for your contribution, dimitrov.adrian!

I updated your account to let you promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and get involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.