Module that allow using your panels with extra way, provide a suitable functionality for template inheritance, and panel embedding, like Views (http://drupal.org/project/views), Node Panel Template provide a visual way to present your nodes, using Panels, but here we can apply the template over the all nodes of content type.

Feautures:
* Make some content-types using panel as template for it's nodes.
* New field type (Panel) which provide a way to embedding panel to node.

Requirements:
* Panels >= 3.x (http://drupal.org/project/panels/)
* Drupal >= 7.x

Git access:
http://drupalcode.org/sandbox/dimitrov.adrian/1438556.git/commit/f1e1553...

Comments

iler’s picture

Status: Needs review » Needs work

You should add README.txt to your modules files. See guidelines for in-project documentation. You should also remove all the other files than README.txt from your master branch. More info here http://drupal.org/node/1127732.

dimitrov.adrian’s picture

Status: Needs work » Needs review

I made a README file.

vaibhavjain’s picture

Status: Needs review » Needs work

Hi,

Please follow the instructions to apply for a full project - http://drupal.org/node/1011698
I dont see a link to your project page, neither a direct git access link to your repo. The above mentioned link cannot be used to clone code onto my local machine.

dimitrov.adrian’s picture

Status: Needs work » Needs review

Added README, homepage and git access from github.

vaibhavjain’s picture

The automated review is clean, you dont have any issues there - http://ventral.org/pareview/httpgitdrupalorgsandboxdimitrovadrian1438556git
However, you need to have the readme file in 7.x-1.x branch too.
will do a manual review in some time.

luxpaparazzi’s picture

Status: Needs review » Needs work

I miss your project page and I suppose your GIT link is not correct, it should begin with http://git.drupal.org/...

@file comment, should contain a description, not the filename:

 * @file
 * node_panel_template.install

WARNING: $node is not set in node_panel_template_field_formatter_view()

I don't find it a good idea mixing HTML into t():
t('Panel field is already added, you can have <strong>ONLY ONE</strong> panel field.')

All HTML should come ideally from template functions or template files.

          $element['wrapper']['layout'] = array(
            '#prefix' => '<div class="panels-choose-layout panels-layouts-checkboxes clearfix">',
            '#suffix' => '</div>',
          );

would make life easier for themers later.

Your files should end with exactly one new-line. You should check these errors with the coder-module.

patrickd’s picture

btw, putting div-tags in #prefix and #suffix is not forbidden (core does this too) ;)

dimitrov.adrian’s picture

Because the few patches (for the panels module) that this module needs, I decide to close it for community and continue developing for internal uses only from our firm.

Sorry about wasting your time all, and thanks for the reports at all.

Cheers!

patrickd’s picture

Status: Needs work » Closed (won't fix)

that's a petty, maybe you come back later

feel free to reopen

cheers

klausi’s picture

Status: Closed (won't fix) » Closed (duplicate)
Multiple Applications
It appears that there have been multiple project applications opened under your username:

Project 1: http://drupal.org/node/1587176
Project 2: http://drupal.org/node/1772350
Project 3: http://drupal.org/node/1453964
Project 4: http://drupal.org/node/1406352
Project 5: http://drupal.org/node/1438600
Project 6: http://drupal.org/node/1929114

As successful completion of the project application process results in the applicant being granted the 'Create Full Projects' permission, there is no need to take multiple applications through the process. Once the first application has been successfully approved, then the applicant can promote other projects without review. Because of this, posting multiple applications is not necessary, and results in additional workload for reviewers ... which in turn results in longer wait times for everyone in the queue. With this in mind, your secondary applications have been marked as 'closed(duplicate)', with only one application left open (chosen at random).

If you prefer that we proceed through this review process with a different application than the one which was left open, then feel free to close the 'open' application as a duplicate, and re-open one of the project applications which had been closed.

avpaderno’s picture

Issue summary: View changes
Related issues: +#1929114: GMap Image Field