Thank You Commenter

Please follow the guidelines to apply for full project access. http://drupal.org/node/1011698

Please update the first post and change the issue status to needs review.

Sorry but

You can use automated tools like pareview.sh for review but you must always do an additional manual review.

See #1410826: [META] Review bonus

you only did a little manual review at one issue

There are still files other than README.txt in the master branch, make sure to remove them. See also step 5 in http://drupal.org/node/1127732
Review of the 6.x-1.x branch:

• ./thank_you_commenter.module: all functions should be prefixed with your module/theme name to avoid name clashes. See http://drupal.org/node/318#naming
  

  function _tyc_mail_tokens($comment) {
  

• Bad line endings were found, always use unix style terminators. See http://drupal.org/coding-standards#indenting
  

  
  thank_you_commenter.module
  

• Drupal Code Sniffer has found some code style issues (please check the Drupal coding standards). See attachment.

This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. Get a review bonus and we will come back to your application sooner.

manual review:

• The functionality of your module can easily be accomplished with Rules (maybe with token module). Are there any benefits your module provides?
  http://drupal.org/project/rules
  http://drupal.org/project/token

Removing the review bonus tag, you can do another 3 reviews and add it again.

Review of the 6.x-1.x branch:

• Bad line endings were found, always use unix style terminators. See http://drupal.org/coding-standards#indenting
  

  
  thank_you_commenter.module
  

• Drupal Code Sniffer has found some issues with your code (please check the Drupal coding standards).
  

  
  FILE: ...tes/all/modules/pareview_temp/test_candidate/thank_you_commenter.module
  --------------------------------------------------------------------------------
  FOUND 4 ERROR(S) AFFECTING 4 LINE(S)
  --------------------------------------------------------------------------------
     1 | ERROR | End of line character is invalid; expected "\n" but found "\r\n"
   141 | ERROR | Files must end in a single new line character
  --------------------------------------------------------------------------------
  

This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. Get a review bonus and we will come back to your application sooner.

manual review:

• "'access arguments' => array('administer comment expire'),": hook_perm() is missing to define that permission.
• "'#options' => node_get_types('names'),": you need to sanitize the type names before printing them, as the #options element is not sanitized for the checkboxes element type. See http://drupal.org/node/28984
• 'tyc_content_types': this setting is not used anywhere and currently leads to heavy confusion as mails are sent in any case. Please implement the functionality or remove that option.

Otherwise this looks nearly ready to me. I'm removing the review bonus tag as your reviews were quite short, you can add it again if you have done another 3 reviews of other projects. Thanks!

Please don't remove the security tag, we keep that for statistics and to show examples of security issues.

Manual review

• warning: Missing argument 2 for variable_get(), called in thank_you_commenter.module on line 110 and 123
• Name is missing in mail it shows Hi !name,
  (Just install module and do not change any thing in mail format and add a comment as Anonymous user module send an email but in email it shows:

  Hi !name,
  Thank you for commenting on: .....

  Works perfectly with !username

• Wrong view your comment link http://domain_name/node/#comment-2, nid is missing after node/

Other suggestion

• If content has proper URL alias, but in email it shows node/NID
• It is possible to add all available variables in Mailtext description, it's easy to user to customize email like User e-mail settings at User settings
• Can add site logo in mail

Sorry for the delay. Make sure to review more project applications and get a new review bonus to get this finished faster.

manual review:

1. "define('AUTHENTICATED_USER_MAILTEXT'": all constants defined by your module must be prefixed with your module's name to avoid name collisions.
2. As your module creates its own variables you should delete them in hook_uninstall().

Although you should definitively fix those issues they are no hard blockers for me, so I would say RTBC.

Thanks for your contribution, vaibhavjain! Welcome to the community of project contributors on drupal.org.

I've granted you the git vetted user role which will let you promote this to a full project and also create new projects as either sandbox or "full" projects depending on which you feel is best.

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

As you continue to work on your module, keep in mind: Commit messages - providing history and credit and Release naming conventions.

Thanks to the dedicated reviewer(s) as well.