Probabilistic weight

Please include Sandbox Project, Git Repository and drupal version to get review.

HI

1) add git repository in summary

git clone http://git.drupal.org/sandbox/grisendo/1791222.git probabilistic_weight

2) Please fix "ventral automated code review" errors
http://ventral.org/pareview/httpgitdrupalorgsandboxgrisendo1791222git

3) Attach screenshot in this page

Thanks

HI,

Still have few more errors. please fix.

FILE: ..._temp/test_candidate/views/probabilistic_weight_handler_sort_weight.inc
--------------------------------------------------------------------------------
FOUND 7 ERROR(S) AFFECTING 3 LINE(S)
--------------------------------------------------------------------------------
13 | ERROR | Class name must begin with a capital letter
13 | ERROR | Class name must use UpperCamel naming without underscores
15 | ERROR | Missing function doc comment
15 | ERROR | No scope modifier specified for function "query"
37 | ERROR | Missing function doc comment
37 | ERROR | Method name
| | "probabilistic_weight_handler_sort_weight::option_definition" is
| | not in lowerCamel format, it must not contain underscores
37 | ERROR | No scope modifier specified for function "option_definition"
--------------------------------------------------------------------------------

Thanks

HI grisendo,

http://drupal.org/coding-standards
please go through this link. you will get brief idea about drupal coding standards

try, you can take your time and fix the issues.
if you are not able to fix. i will help you.

Thanks

ok cool,
we can check with other reviewers.

Reviewers,
Please review this module.

Thanks

Review

README.txt

Your README looks fine.

project page

This might be just a little pain in the butt type of thing, but as a personal preference I really like to see better project pages. At the moment your project page does give a full, valid desciption of what the module does with an example use-case. But for something like this I believe it would be helpful to at least at some screenshots of admin pages or some other sort of visual to go with the descriptions. Please take a moment to make your project page follow tips for a great project page.

Master Branch

Not using it, good man! Git branch is 7.x-1.x.

Major coding standards / best practice issues

You've already covered the ventral tests with an acceptable reason for not being able to comply. I honestly don't know of any solution to get around this so I'll just say let it slide, but I would welcome a second opinion.
I´ve attached the automated report of Coder's output as a .png file to this comment.

License

Doesn't exist, just how we like it.

access administration vs. administer site configuration

Irrelevant for this module.

files[] without classes or interfaces

class probabilistic_weight_handler_sort_weight extends views_handler_sort, your declaration of files[] in the .info file is valid.

PAReview: 3rd party code

No apparent 3rd party code exists.

Multiple Applications

Another project application exists, but it has been closed so all is well.

Already Approved

Nope not yet.

Idle Application

Not idle.

Code too short

Code length is fine.

Notes

I also took the time to manually try the module out and it works as described. I would urge you to make your project page the best it can be, but I won't hold up the release of this over something piddly like that.

Result

So, without further ado, I hereby mark this module RTBC.

Thank your for your reviews. When finishing your review comment also set the issue status either to "needs work" (you found some problems with the project) or "reviewed & tested by the community" (you found no major flaws).

manual review:

1. please add the differences to existing modules to your project page, e.g. http://drupal.org/project/random_weight
2. probabilistic_weight_validation(): do not use the raw $form_state['input'] where possible, always use $form_state['values'].
3. probabilistic_weight_validation(): please add a comment to the first line in the function. What the heck is going on here?
4. probabilistic_weight_views_api(): there is no Views 2.0 API in Drupal 7?
5. "t('Probabilistic weight fields') . ': ' . $field['field_name'],": do not concatenate translatable strings, always use placeholders with t().
6. probabilistic_weight_handler_sort_weight: is that order_by() MySQL specific or does that work on any database? Could you clarify that in the README.txt?

Removing review bonus tag, you can add it again if you have done another 3 reviews of other projects.

Pareview

Automated review outputs errors but it is a view issue (#7) .

Documentation

You should add a description under the text field explaining that the value must be lower or equal than 1 (same as error message) in probabilistic_weight_field_widget_form().

The usage of the module is not straightforward so you should add a step by step process somewhere. Can't make it working: my list is always ordered in a same way :( i give up

Read Me

Too much explanation with Random Weight. The most important (how does it work) is skipped.

I will review it deeper when I'll make it work!

ps: it works now no idea why it didn't...

manual review:

1. "manual review 4" is not a useful commit message. Please try to be more descriptive, see also http://drupal.org//node/52287
2. probabilistic_weight_field_widget_form(): this is vulnerable to XSS exploits. If I enter <script>alert('XSS');</script> as help text for the field I get a nasty javascript popup on the form when editing this field. You need to sanitize user provided input in #description. Please read http://drupal.org/node/28984 again.

Security issues are blockers, otherwise this looks nearly ready. Removing review bonus tag, you can add it again if you have done another 3 reviews of other projects.

Misstyping

Please don't remove the security tag, we keep that for statistics and to show examples of security problems.

Looks RTBC now. Removing review bonus tag, you can add it again if you have done another 3 reviews of other projects.

Three new reviews for Bonus Review

no objections for more than a week, so ...

Thanks for your contribution, grisendo!

I updated your account to let you promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and get involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.