[D6] Youtubechannel

Hi soycreativo,

I looked at your contribution and created a few issues in the issue queue. Please change this back to "needs review" when those are fixed.

Closing, feel free to re-open if this was a mistake.

As I have taken over the project , I have made major changes to the code.
Please review this application.

Changing status to Needs Review

Changed description

Marking in description that this application is for which module and what is repo path

youtubechannel application name changed

Applying for pareview: review bonus.

@Parwan005: You already have the vetted git status and the original creator of the project has abandoned so I don't really see the point of passing this module by the PAReview as the main objetive is to grant access to the creator the possibility to auto promote projects.

Logicdesign..i do not have full project access to promote my projects... My project calc was only one time single promote project so i have to go through this again. Other thing i have maintained this project along with the creator after gettting maintainer rights , so we both worked on this.

Thanks
parwan

I'm confused. Who is applying for access in this issue?

Since both have worked on the project , so both are applying though this.

manual review:

1. project page is too short, see http://drupal.org/node/997024
2. "'access arguments' => array('youtube channel admin'),": that permission is not defined?
3. "theme_image(..."_ do not hard code the theme function, use theme('image', ...) instead so that custom themes can override it.
4. youtubechannel_getview(): this is vulnerable to XSS exploits. If I enter 110"><script>alert('XSS');</script> as Youtube Channel video width I get a nasty javascript popup when the block is displayed. You need to sanitize user provided input before printing. Please read http://drupal.org/node/28984 again.

Removing review bonus tag, you can add it again if you have done another 3 reviews of other projects.

Thanks for the review klausi. Have fixed the issues raised by you. Will apply for review bonus now :)

Applying for pareview: review bonus.

manual review:

1. youtubechannel_menu(): the menu entry has no access arguments, so it always returns access denied.
2. youtubechannel_getview(): no need to use check_plain() on $youtube_user and $max_results - those variables are never printed to HTML.
3. youtubechannel_getview(): you should not create the HTML markup in that function, that should be done in a theme function or the template.
4. "Could not fetch videos from youtube channel.": all user facing text must run through t() for translation.

Removing review bonus tag, you can add it again if you have done another 3 reviews of other projects.

Hi klausi,

I have fixed the issues raised by you now. Will apply again for pareview now.

Thanks
parwan

Applying for review bonus.

Applying for pareview: review bonus.

Hey,

Automated review:
PAReview has som issues:

93 | ERROR | A cast statement must be followed by a single space
97 | ERROR | Using the e flag in preg_match is a possible security risk. For
| | details see http://drupal.org/node/750148

You should run your project through the review before applying for review, but these issues will need to be addressed.

Manual review:
Code looks decent, though when you're only using a single script or css file, there is no need to subfolder them.
I also think the vars you send to the template file could be sent explicitly in hook_theme to clarify what information is available.

Documentation review:
Your README file is very short, but lacks in terms og system requirements, target audience, installation guide. Remember your module may be the first module a drupal developer downloads, and he might not know how to install a module og activate a block. he just wants his youtube vids shown. Please create a README.txt that follows the guidelines for in-project documentation.

Hi,

About automated review: I have seen that and its only one preg_match issue. Which i already have posted in forums but found no answer to it. Dont know why code sniffer throws that. I have fixed cast statement issue. Here is ventral report : http://ventral.org/pareview/httpgitdrupalorgsandboxsoycreativo1123084git

About manual review: I really dont see need to do any of both. I do not want to use separate variables for each, would rather go for array.

About documentation: README clarifies what this module does. Other details of the project are available in project page : http://drupal.org/sandbox/soycreativo/1123084

Please don't remove the security tag, we keep that for statistical purposes and to show examples of security problems.

manual review:

• "'access arguments' => array('access administration pages'),": The administration menu callback should probably use "administer site configuration" - which implies the user can change something - rather than "access administration pages" which is about viewing but not changing configurations.

That could be considered as a blocker, but I'm sure you'll fix that ASAP. Otherwise looks RTBC to me. Removing review bonus tag, you can add it again if you have done another 3 reviews of other projects.

Hi klausi,

thanks for RTBC. Have changed "access arguments" to "administer site configuration". Do i still have to add 3 more reviews?

Thanks

Applying for pareview

More manual reviews added

Applying for pareview: review bonus

no objections for more than a week, so ...

Thanks for your contribution, parwan005 and josueggh!

I updated your account to let you promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and get involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.

I am giving credits to the users who participated in this issue.