Closed (fixed)
Project:
Panopoly
Version:
7.x-1.x-dev
Component:
Search
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
3 Sep 2013 at 18:57 UTC
Updated:
26 Feb 2015 at 21:24 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
dsnopekPatch is attached!
Comment #2
dsnopeksearch_api_db 7.x-1.0-rc3 was just released! Here are the release notes:
https://drupal.org/node/2100145
It includes a performance fix and adapts search_api_db to the fixes in search_api 1.8 mentioned above.
New patch attached!
Comment #3
dsnopekThe following Search API modules were recently released:
Attached is a patch to upgrade to them!
Comment #4
dsnopekOne quick note: this will still need extensive testing before it can actually be committed to Panopoly. The upgrade process is not entirely clean from where Panopoly 1.0-rc5 is and the current Search API stuff. There was even specific mention of Panels in the search_api 1.9 release notes.
I actually have a confession to make: while I keep tracking these release, Panopoly Search is the one Panopoly module I don't personally use! However, I do plan to eventually give it a try.
Comment #5
dsnopeksearch_api 1.10 and search_api_db 1.1 recently were released - here are the release notes:
https://drupal.org/node/2152787
https://drupal.org/node/2152819
Its all bug fixes and UI improvements. There is a known bug in search_api 1.10 and they say that a 1.11 is coming shortly.
Anyway, my disclaimer to this patch still stands! Some of the updates between what Panopoly is on and current aren't fully automatic updates, so we'll need to do extensive testing before comitting this.
Comment #6
lsolesen commentedThere is this #2153931: Write Behat test for the search functionality - and we should remember this also #2063715: Panopoly Search update breaks from older versions (for example, 1.0-rc3, 1.0-rc4)
Could you outline the other tests you think should be created to have enough tests to see whether it causes any issues?
Comment #7
dsnopekSomeone with more experience with the search stuff will have to do that - unfortunately, this is the one Panopoly module that I don't personally use. :-) @populist is going to work on some search stuff over the next couple of days, so maybe he'll be able to work on this!
Comment #8
dsnopekNew updates are out and a new patch is attached!
Here are the release notes:
Comment #9
mcrittenden commentedThe patch in #8 seems to be working fine for me on Panopoly 1.1. The site built/installed correctly and nothing is obviously broken. Hesitant to mark RTBC since we aren't really hitting Search very hard yet, but I'll update when that happens.
Comment #10
dsnopekHere is another untested patch to upgrade to the latest search_api releases. Again, this needs manual testing (especially upgrade testing) from previous sites using both search_api_db and search_api_solr.
Here are the release nodes:
Comment #11
dsnopekThere have been a few new releases...
facet_api 1.5:
https://www.drupal.org/node/2305619
search_api 1.13:
https://www.drupal.org/node/2308061
So, this patch needs to be updated!
Comment #12
dsnopekHere's a new version of the patch which does the updates mentioned in #11. I still tested it, but I'm working on a project that may allow me to (at least for database search).
Comment #13
mrfelton commentedWe are using this in production and haven't had any issues.
Comment #14
dsnopek@mrfelton: Awesome, thanks! I'm actually most worried about updates of existing sites, since the release notes for some of the releases led me to believe that updating wasn't fully automatic. :-/ Anyway, if you have any older sites you could test upgrading, that would be amazing. :-)
Comment #15
mrfelton commentedI actually just patched an older site with this yesterday, and everything seems fine in terms of the Search API integration. It's a site running on Pantheon, using Apache Solr.
Comment #16
dsnopekAh, great! I'm also going to be updating some older sites (using the database, not solr) for a client project over the next week or so. I think we may be close to finally being able to commit this, close to the 1 year anniversery of this issue. :-)
Comment #17
dsnopekTested on a fresh install and was getting the following error when searching (via database search):
I think our export of the server and index need to be updated. I'll post a patch soon if I figure out a fix.
Comment #18
dsnopekI rebuilt the database server/index and re-exported them, and now this is working on a fresh install! New patch is attached.
I'm going to test a migration from a super old version of Panopoly in a moment. However, we should probably test some upgrades from more recent version. It's a shame we don't have any tests for search, there's the beginning of some here: #2150047: Empty search should yield message "Enter your keywords", but that only tests error conditions. Here's a new issue for testing #2329387: Write Behat tests to ensure search works after install and provides facets
Comment #19
dsnopekDid the upgrade test from super old Panopoly with database search. I had to re-index the content, but otherwise it worked! I think if I would have been patient, the content would have been re-indexed on cron anyway.
Comment #20
dsnopekHere is a new version of this patch, updated for:
search_api_solr 1.6:
https://www.drupal.org/node/2334841
search_api_db 1.4:
https://www.drupal.org/node/2334849
Comment #21
dsnopekThis patch has gotten a lot of use on a client project and I think is almost ready to committed! I'd really like to do one more manual upgrade test from Panopoly 1.0-rc5, just to make double extra sure that the upgrade path is fine. I'm super excited to finally get this in - it only took over a year. :-)
Comment #22
dsnopekThis patch needs to be updated for search_api 1.14:
https://www.drupal.org/node/2398657
Looks like mostly bug fixes - the release notes don't sound like there should be anything problematic.
Comment #23
dsnopekAlright, here's an updated patch. Also, I just did one last manual test upgrading from Panopoly 1.0-rc5 and everything worked great! I think it's finally time to commit this...
Comment #25
dsnopekCommitted!
Comment #26
dsnopekUnder some pretty crazy circumstances, I saw this error when updating a test site during
search_api_db_update_7104():The solution was to disable panopoly_search, delete all the indexes, run the updates and then re-enable panopoly_search.
Honestly, I'm not sure if this was because of the patch that I'm testing or the weirdness I have on this test site or what. It might not happen for anyone else, but I'm adding a note here in case I need this for the release notes of the next release. :-)
EDIT: Possibly related issue: #1347438: Reverting Features Drops Search API DB tables
Comment #27
dsnopekHeh, actually, that solution didn't work. Here's one that appears to have now:
Comment #28
mizage@gmail.com commentedWill #27 fix this "SQLSTATE[42S02]: Base table or view not found: 1146 Table 'drupal.search_api_db_database_node_index_text' doesn't exist"? Do I need to do #26 as well?
cheers!
Comment #29
dsnopek#27 worked for me! Although, I did do #26 first. Please try one of them and let us know what worked for you!
Comment #30
dsnopekI've added an improved version of #27 to the release notes for Panopoly 1.16 in case anyone else comes across this problem:
https://www.drupal.org/node/2425263#special_instructions
Comment #31
mizage@gmail.com commentedUnfortunately I'm still seeing this issue. I upgraded to 1.16 this morning.