Module development and code questions

Hi,

I posted this in the "News and Announcements Forum", but I thought I'd get some technical criticism here.

I've written a module that enables two-factor Authentication in Drupal. How it works:

1) User logs in with username and password.
2) Drupal verifies password and proceeds to call user on his registered phone number.
3) User answers phone and is prompted for a PIN code.
4) Drupal verifies PIN code an lets user into site.

I wrote a new auth module for authentication with remote IMAP servers. My hook_auth implementation returns TRUE but users can't login. Should I implement another hooks?

Any hint? This is the code:

<?php

...

/**
* Implementation of hook_auth().
*/
function imapauth_auth($username, $password, $server) {

//IMAP extension not loaded
if (!function_exists('imap_open')) {
watchdog('php', t('IMAP extension not loaded. IMAP module couldn\'t be used to authenticate users.'), WATCHDOG_WARNING);
return false;
}

if (variable_get('imapauth_enabled', 0) == 0) {
return false;
}

$domains = split("/\r\n|\n|\r/", variable_get('imapauth_domains', array()));

$valid = false;
foreach ($domains as $d) {
$domain_settings = split(",", $d, 2);

if ((trim($domain_settings[0]) == $server) or trim($domain_settings[0]) == '*') {
$valid = true;

if (array_key_exists(1, $domain_settings)) {
$mailbox = trim($domain_settings[1]);
}
else {
$mailbox = "{" . $server . ":143}INBOX";
}
}
}

//This domain is not valid for IMAP authentication
if (!$valid) {
return false;
}

$mbox = @imap_open($mailbox, $username, $password);

if ($mbox) {
$minfo = @imap_mailboxmsginfo($mbox);

if ($minfo) {
$login = true;
}
else {

I am using the image module and for the life ofme cannot figure a way to make the thumbnails align to the left:

http://crown-internet.com/drupal/

It would be great for the thumbnails to align to the left instead of to the top of the content.

Any ideas would be greatly appreciated.

Thanks,

John.

Hi,

I've managed to write an authentication module, however, users are
required to enter the username as "username@server" before it gets activated.

Is it possible to direct all logins (with and without the @server part)
to an authentication module?

Best regards.

Frank

Hello,

I need a guestbook for Drupal 4.6.2.

I have tested the "guestbook-4.6.0.tar.gz" but it functioned not correctly. If you can, please help me.

Amazon made a change to their XML output that requires a change in Amazon associate tools. If you downloaded the module before 7/31/2005 you should get a fresh copy. The include files are the ones that changed.

http://drupal.org/node/18842